Experiments with select - #54
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a302e8501
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| add_executable(select512_experimental_tests | ||
| src/tests/select512_experimental_tests.cpp) |
There was a problem hiding this comment.
This adds a new test binary, but the test suite is not registered with CTest and the checked CI workflow .github/workflows/build-test.yml runs only the existing binaries explicitly (./unittests, ./louds_tree_tests, ./dfuds_tree_tests, ./benchmark_tests, and ./test_rmm, with the SDE job following the same pattern). As a result, regressions caught by select512_experimental_tests will not fail CI unless someone runs this target manually; please add this executable to the workflow or register it via CTest and run ctest.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 90.10% 90.31% +0.20%
==========================================
Files 39 41 +2
Lines 8735 9109 +374
Branches 1418 1466 +48
==========================================
+ Hits 7871 8227 +356
- Misses 447 456 +9
- Partials 417 426 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7109637 to
8799396
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8d73987c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const __mmask8 mask = _mm512_cmpgt_epu64_mask( | ||
| prefix, _mm512_set1_epi64(static_cast<int64_t>(rank))); | ||
| const uint32_t lane = _tzcnt_u32(static_cast<uint32_t>(mask)); |
There was a problem hiding this comment.
When PIXIE_AVX512_SUPPORT is enabled and the requested bit does not exist (for example, select1 on an all-zero block), mask is zero, so _tzcnt_u32(0) produces lane 32 and the subsequent x[lane] reads beyond the eight-word block. This also makes the AVX-512 wrappers inconsistent with the scalar/AVX2 variants and the new MissingBitReturnsSentinel expectation; return 512 when mask == 0 before extracting the lane.
Useful? React with 👍 / 👎.
1 participant
No description provided.