refactor(module): simplify and fix configMerge#4203
Merged
Conversation
khassel
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a hard time understanding
configMerge- the oldargumentsslicing and nested loops took me a while. The jsdoc didn't help much. After it finally clicked, I rewrote it to be readable: rest param + a simplefor...ofinstead of thewhile-stack.And there's one real behavior fix. With this default and user config:
the old code merged them into
{ foo: { 0: 10, 1: 20, a: 1 } }. Now the array just replaces the object ->{ foo: [10, 20] }.I added a small test for that case.
Only affects modules using
configDeepMerge: truethat override an object default with an array, so the impact is tiny.