Skip to content

refactor: convert Translator to ES module#4202

Merged
khassel merged 1 commit into
MagicMirrorOrg:developfrom
KristjanESPERANTO:translator
Jul 12, 2026
Merged

refactor: convert Translator to ES module#4202
khassel merged 1 commit into
MagicMirrorOrg:developfrom
KristjanESPERANTO:translator

Conversation

@KristjanESPERANTO

Copy link
Copy Markdown
Collaborator

Another step towards ES modules: this converts Translator to a proper module and imports it where needed, instead of relying on it being globally available.

The goal is to gradually get rid of the old global-script style in the core. It makes dependencies explicit, reduces hidden coupling and keeps the codebase easier to maintain going forward.

The code change is tiny - the bigger and harder part was adapting the tests to the new loading behavior.

Comment thread js/main.js Dismissed
@khassel khassel merged commit ed95826 into MagicMirrorOrg:develop Jul 12, 2026
13 checks passed
@KristjanESPERANTO KristjanESPERANTO deleted the translator branch July 12, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants