Illusion Temple Mini Game - Event

[bulgarashi]

Illusion Temple mini-game event

Implements the full Illusion Temple event: a team-based PvP mini game where two teams (Allied Forces / Illusion Forces) fight over a sacred relic held by a randomly-spawning Stone Statue.

What's included

• Core game loop: statue → relic pickup → carry → deliver to own team's storage → score. Relic drops on death or on leaving the event and can be picked up by anyone. A team needs at least 2 points, and more than the opponent, to be declared the winner (a 1:0 finish is a draw, matching the original event).
• Teams & state: players are split into two teams on start, each gets a live per-player state update (own team's positions, current relic carrier, remaining time) and an end-of-game result screen.
• Rewards: experience is granted automatically to the winning team; other reward types (e.g. item drops) are only granted once the player explicitly claims them by closing the result dialog, matching the original "click Close to be compensated" flow.
• Skill points & special skills: killing an enemy player (+1) or a roaming arena monster (+2) builds a skill-point pool (start 10, cap 90) that fuels four event-only skills (210 Order of Protection, 211 Restraint, 212 Tracking, 213 Weaken), each costing 10 points.
• Admin-configurable minimum player count (EF migration included) instead of hardcoded per event.
• Corrected packet layouts for IllusionTempleState/IllusionTempleResult (missing field, wrong offset, and a padding gap that the original client's C struct expects) — new packets for event state, holy-relic notification, skill usage/points, and reward requests.
• Scheduling: starts every 2 hours (matching the official Webzen schedule), plus a GM chat command to force a start for testing.
• Map data fixes: corrected statue/guardian/relic-box spawn positions on all six temple maps (verified against a working Season 6 Episode 3 server), added the 32 roaming arena-monster spawns (temple 6 has none), and fixed each temple's safezone map (previously defaulted to itself, so a player warped to "safezone" was sent right back into the arena).
• Update plugin so existing databases get all of the above without a full reinstall (including a fix for a ticket-item number swap).
• Test coverage for entrance timing, minimum-player handling, team assignment (even/odd counts), the statue/relic loop, scoring, and the reward flow.

Known issues

• On the end-of-game result screen, the displayed character class is wrong when tested with a 1.04d client, because that client's class IDs don't match Webzen's numbering. Needs a client-version-aware class ID mapping in the result packet.

[sven-n]

Review

Substantial, well-documented feature work — the comments explain why (the client's C-struct padding, the hardcoded arena barriers, the score-table-before-warp ordering) rather than restating the code, and the packet-layout corrections look right. CI is green (Codacy is action_required, not a failure). But there are several real bugs, one of which makes a headline feature of the PR a no-op.

Blocking

1. UpdateVersion.IllusionTempleData = 100 collides with AddCastleSiegeData = 100 — src/Persistence/Initialization/Updates/UpdateVersion.cs:530

IConfigurationUpdatePlugIn documents the version as "must be unique over all DataInitializationKeys", and it's used two ways, both of which break:

• Key => (int)Version (UpdatePlugInBase.cs:16) keys the strategy provider. StrategyPlugInProvider.ActivatePlugIn (StrategyPlugInProvider.cs:79-86) keeps the first registration and logs "will not be effective" for the second, and AvailableStrategies returns only the effective ones — so either the castle siege update or the illusion temple update disappears from the update list entirely.
• DetermineAvailableUpdatesAsync filters with !installedUpdates.Contains(up.Version) (DataUpdateService.cs:59). Any existing DB that installed update 100 already considers this update installed.

So "existing databases get all of the above without a full reinstall" doesn't actually happen. Should be 104. The XML doc is also missing its opening <summary> tag.

2. Re-entrant warp in OnObjectRemovedFromMapAsync — IllusionTempleContext.cs:700-732

GameMap.RemoveAsync awaits ObjectRemoved inline (GameMap.cs:177-180), and Player.WarpToAsync calls TryRemoveFromCurrentMapAsync → map.RemoveAsync before PlaceAtGateAsync (Player.cs:880-889). So the handler's WarpToAsync(devias) runs nested inside whatever warp removed the player:

MovePlayersToSafezoneAsync → WarpToSafezoneAsync → RemoveAsync
   └─ OnObjectRemovedFromMapAsync → WarpToAsync(Devias) → PlaceAtGate(Devias), MapChange
   ← returns
PlaceAtGate(safezone gate), MapChange     ← player now on two maps, two MapChange packets

This fires on the normal end-of-game path, on ClaimRewardAsync, and on any other warp off the temple map. It also silently overrides the per-temple SafezoneMapNumber this PR just fixed. Suggestion: limit the handler to state cleanup (relic drop, _teams/_skillPoints removal, party kick) and leave the warping to ClaimRewardAsync / MovePlayersToSafezoneAsync.

3. Every failed entry is reported to the client as success — RemoteView/MiniGames/Extensions.cs:84-87

public static byte ToIllusionTempleEnterResult(this EnterResult enterResult)
{
    return 0;
}

The parameter is ignored and the remark itself says failures should be 1. ShowMiniGameEnterResultViewPlugIn sends this for every refusal.

4. Item rewards are silently lost for most winners — IllusionTempleContext.cs:844-869

ClaimRewardAsync defers non-experience rewards to DoesRewardApply, which for WinnerOrInWinningParty requires Winner.Party == player.Party. But each departing winner goes through KickMySelfAsync → Party.ExitPartyAsync, which disposes the party once fewer than 2 members remain (Party.cs:417-436), nulling everyone's Party. After that only the single arbitrary player returned by Winner (a FirstOrDefault over a ConcurrentDictionary, :229) still qualifies. On a 2v2 the second winner gets nothing; on larger teams most of them get nothing. Experience is unaffected, since it's granted eagerly in GameEndedAsync.

5. The 20s preparation delay runs inside OnGameStartAsync — :584-593

The tests drive OnGameStartAsync directly (IllusionTempleContextTest.cs:376-379), so ~15 tests each block for the full PreparationDuration, adding roughly five minutes to the suite. Make it a protected virtual TimeSpan the tests can shorten, or move the preparation phase out of the start hook.

Correctness

6. TeleportToStartCoordinatesAsync doesn't do what its comment says — :919-933. cordinatesAlliedForces is a local copy of a readonly field, so += new Point(1, 0) is discarded every iteration and every member of a team is moved to the same tile. Either spread by index or drop the += and the // every player on differend point comment (also a typo). The two fields don't follow the _camelCase convention used elsewhere in the file, and duplicate the literals in GetSpawnGate.

7. player.Party = null; — :548. The only other assignments to Party are inside Party itself; this bypasses KickMySelfAsync and leaves the player in the old party's _partyMembers array. EnterMiniGameAction already kicks non-party mini-game entrants properly (EnterMiniGameAction.cs:125-128), so the line is redundant at best.

8. Special skills hit your own team. UseRestraintAsync (:465) and UseWeakenAsync (:508) only exclude target == player — no team check, so you can freeze a team mate for 15s. UseSkillAsync also doesn't check IsEventRunning or that the caster is alive.

9. Reported experience is wrong for ExperiencePerRemainingSeconds — :899. _grantedExperience sums RewardAmount, but GiveRewardAsync grants seconds * RewardAmount (MiniGameContext.cs:573-580); AddExperienceAsync also applies server rates. The seeded reward is plain Experience, so this only bites custom configs — but the score board will lie.

10. Relic race and item leak — :272-304. _relicCarrier is checked and set with awaits in between (same in OnPlayerPickedUpItemAsync), so two players talking to the same statue can both walk away with a relic. Separately, the Item is created via CreateNew<Item>() before the inventory-space check, so a full inventory leaves an orphan entity in the persistence context.

11. The relic is never reclaimed at game end. A carrier who never delivers keeps "Cursed Castle Water" in his inventory permanently.

12. Dead paths. IllusionTempleEventStatus.Ended and WaitingRoom are never sent — the client's event UI is never told the match is over. IIllusionTempleSkillEndedViewPlugin has a remote-view implementation but no caller, so the special-skill effects never notify the client when they expire.

13. Hardcoded Devias exit gate duplicated in ClaimRewardAsync (:860-868) and OnObjectRemovedFromMapAsync (:711-719), rather than the map's configured safezone — which is what the SafezoneMapNumber map fixes in this same PR exist for.

Consistency / style

• EnterMiniGameAction.ShowRefusalAsync: hardcoded English strings where the codebase (and this PR) uses localized PlayerMessage resources; several needless $""; "Killers can`t enter!" uses a backtick. These messages now fire for all mini games, which is a behavior change beyond the PR's stated scope.
• Copy-paste docs: StartIllusionTempleEventChatCommandPlugIn — "handles the startcc command"; IllusionTempleGameServerState — "for a chaos castle event"; MiniGameContext.GetSpawnGate — "Gets spown gate" with empty <param>/<returns>.
• StartIllusionTempleEventChatCommandPlugIn.HandleCommandAsync is async with no await (CS1998) and gives the GM no feedback when the plugin isn't registered.
• IllusionTempleStartPlugin uses literal [Display] strings while its siblings use PlugInResources; the two new sub-packet handlers lack [Display] entirely.
• File/type name mismatches: IllusionTempleEnterHandlerPlugin.cs → …PlugIn (its copyright header names a file that doesn't exist), IllusionTempleUserCountViewPlugin.cs → …PlugIn, and IllusionTempleStartPlugin breaks the PlugIn suffix convention.
• TalkNpcAction: cases 383/384 are byte-identical (collapse them), case bodies aren't indented, and both carry the same misleading comment. TalkToNpcTeamStorageAsync's body is indented one level too deep.
• Member ordering: IllusionTempleScore.MinimumWinningScore sits between properties; SorcererSpiritPositions is declared after a method in all six map files.
• IllusionTempleTeam.cs lives in MiniGames/ but declares namespace MUnique.OpenMU.GameLogic.
• Unrelated whitespace noise in MiniGameContext.cs:37,91 (trailing whitespace + a stray blank line) and an extra blank line in Player.cs:1550.
• GameContextTestHelper now sets MaximumLevel = 400 for every test using the helper — a global change tucked into a feature PR.
• Group == 14 && Number == 64 is repeated three times in the context; extract constants.
• The arena-monster stat table and map spawn coordinates are duplicated verbatim between NpcInitialization.CreateIllusionSorcererSpirits and IllusionTempleDataUpdatePlugIn. Worth a shared source given how easily these drift.
• FixTicketItemNumbers changes Number but not the deterministic SetGuid(group, number) id — deliberate (changing it would break owned-item FKs), but it means an updated DB's "Illusion Sorcerer Covenant" keeps the id of (13, 50) while a fresh install gets (13, 51). That divergence should at least be documented, since later updates that resolve items by Guid will hit it.
• Tests reach into private/protected members by reflection (pragmatic, given the constructor starts a real-time countdown, but brittle), and FinishesWhenTooFewPlayersRemainAsync asserts only PlayerCount < 2 — the precondition it just created, not that the event finished.

Questions

• The old Cursed Statue / Captured Stone Statue spawns (NPCs 658–668) are deleted from all six maps. Fresh installs are fine, but existing DBs only get the replacement via the update plugin — which currently can't run (see Bug at player appearance - weird wing is shown #1). Intended?
• The known issue about wrong class IDs on 1.04d clients is fine to defer, but IllusionTempleResult has no client-version handling at all right now, so it will be wrong for every client that doesn't use Webzen's numbering.

---

Generated by Claude Code