Add hydrofracture mask input to ismip7_run/ismip7_ais test case - #989
Merged
Merged
Conversation
trhille
changed the title
isimp7_run/ismip7_ais test case
trhille
changed the title
isimp7_run/ismip7_ais test caseismip7_run/ismip7_ais test case
Collaborator
Author
TestingThese changes correctly place the fracture output directories at the same level in the directory structure as |
This was referenced Sep 16, 2026
- Fix ismip7_forcing fracture output paths (excess_melt, lake_properties,
shelf_collapse) to use {model}_{scenario}/{category}/ layout, matching
atmosphere and ocean_thermal_forcing outputs.
- ismip7_ais: optionally apply the Path C calvingMask via a new
fracture_basepath cfg option, enabling mask calving and the
hydrofracture vulnerability gating added in MALI PR MPAS-Dev#187
(config_require_extensional_stresses_for_mask_calving,
config_calving_fracture_toughness). Disabled by default and per
experiment when no mask file is found (e.g. ctrl, ocx).
- users_guide/ismip7_forcing: fix fracture output path examples to the
corrected {model}_{scenario}/{category}/ layout; document it in the
Output Layout section.
- users_guide/ismip7_run: document fracture_basepath and
calving_fracture_toughness config options, the shelf_collapse forcing
directory, and add a Mask Calving (Path C) section describing the
hydrofracture vulnerability gating from MALI PR MPAS-Dev#187.
- developers_guide/ismip7_run: note the new mask calving setup step in
SetUpExperiment.
…rofracture_forcing
- Remove the separate fracture_basepath cfg option; the Path C shelf
collapse mask is now looked up at
{forcing_basepath}/{model}_{scenario}/shelf_collapse/, the same tree
used for atmosphere/ocean forcing.
- Add use_hydrofracture_forcing (default true) to toggle mask calving.
historical, ctrl, and ocx scenarios never use hydrofracture forcing
regardless of this setting.
- When use_hydrofracture_forcing is true for any other scenario, the
mask file is now required: setup fails with an error if it is
missing, instead of silently leaving mask calving off.
- Update users_guide/ismip7_run, users_guide/ismip7_forcing, and
developers_guide/ismip7_run docs to match.
- historical/ocx experiments now start in 2007/2008 instead of 1990/2000. - Add config_fem_extension_method = 'ismip7-era' to AIS and GrIS namelists. - Drop mode="forward;analysis" from the mask_calving stream.
trhille
force-pushed
the
landice/ismip7_run_fracture
branch
from
September 16, 2026 17:40
35e4ce3 to
48099b8
Compare
matthewhoffman
approved these changes
Sep 19, 2026
matthewhoffman
left a comment
matthewhoffman
left a comment
Member
There was a problem hiding this comment.
@trhille , I left a number of detailed comments, but I leave it up to you if you want to address any of them before merging. Feel free to merge yourself when you are happy with any additional tweaks.
trhille
commented
Sep 21, 2026
Remove a hard-coded setting of config_calving = 'none' when using mask calving. We want to be able to use both internal stress-based calving laws and mask-calving simultaneously.
trhille
commented
Sep 21, 2026
trhille
commented
Sep 21, 2026
Update docs to remove statements that `config_calving` is set to `'none'` when using mask calving. Co-authored-by: Trevor Hillebrand <trhille@lanl.gov>
trhille
commented
Sep 21, 2026
Change basicmesh to minmesh to reduce file size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge sets up the run to use hydrofracture mask forcing in the
isimp7_run/ismip7_aiscase. It also fixes an issue with the output path of theismip7_forcing/fracturecase being inconsistent with theatmosphereandocean_thermal_forcingcases.This also includes some changes to the ais namelist.landice file and experiment set up, including making start times consistent with initial conditions and updating boundary conditions.
Checklist
Testingin this PR) any testing that was used to verify the changes