Fix GetInfo failing with INTERNAL: proto declares it unary but the servicer yields - #68
Closed
SAY-5 wants to merge 1 commit into
Closed
Fix GetInfo failing with INTERNAL: proto declares it unary but the servicer yields#68SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Collaborator
|
Thanks for the PR! Two things before I can review this properly:
Once it's retargeted I'll take a proper look at the fix. |
Author
|
Retargeted to develop. On discovery: I was searching open GitHub issues around gRPC servicer bugs and this one stood out because the unary/streaming mismatch had a clear repro. |
Collaborator
|
Closing this as it was also addressed in #69. Thanks for the retarget and context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67. The proto declares GetInfo as a unary RPC, but DisciplineServer.GetInfo yields, so gRPC gets a generator where it expects a DisciplineProperties message and every call fails with StatusCode.INTERNAL. Changed the servicer to return the message, dropped the matching
[0]indexing in the client, updated the two unit tests, and added an integration test that calls get_discipline_info against a real server so the two sides can't drift again.