Skip to content

Fix GetInfo failing with INTERNAL: proto declares it unary but the servicer yields - #68

Closed
SAY-5 wants to merge 1 commit into
MDO-Standards:developfrom
SAY-5:fix-getinfo-unary
Closed

Fix GetInfo failing with INTERNAL: proto declares it unary but the servicer yields#68
SAY-5 wants to merge 1 commit into
MDO-Standards:developfrom
SAY-5:fix-getinfo-unary

Conversation

@SAY-5

@SAY-5 SAY-5 commented Jul 27, 2026

Copy link
Copy Markdown

Fixes #67. The proto declares GetInfo as a unary RPC, but DisciplineServer.GetInfo yields, so gRPC gets a generator where it expects a DisciplineProperties message and every call fails with StatusCode.INTERNAL. Changed the servicer to return the message, dropped the matching [0] indexing in the client, updated the two unit tests, and added an integration test that calls get_discipline_info against a real server so the two sides can't drift again.

Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
@chrislupp

Copy link
Copy Markdown
Collaborator

Thanks for the PR! Two things before I can review this properly:

  • Could you retarget this to develop instead of main? We merge all changes there first, as main is reserved for releases. (Sorry, don't have a CONTRIBUTING.md yet spelling this out. Contributions so far have mostly come from people already close to the project, so it hasn't come up. Will be adding one soon.)
  • Out of curiosity, how did you come across this issue? Just want to understand a bit about how contributors are finding us.

Once it's retargeted I'll take a proper look at the fix.

@SAY-5
SAY-5 changed the base branch from main to develop July 27, 2026 21:34
@SAY-5

SAY-5 commented Jul 27, 2026

Copy link
Copy Markdown
Author

Retargeted to develop. On discovery: I was searching open GitHub issues around gRPC servicer bugs and this one stood out because the unary/streaming mismatch had a clear repro.

@chrislupp chrislupp added the duplicate This issue or pull request already exists label Jul 27, 2026
@chrislupp

Copy link
Copy Markdown
Collaborator

Closing this as it was also addressed in #69. Thanks for the retarget and context.

@chrislupp chrislupp closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetInfo is implemented as a generator but declared unary, so the RPC always fails

2 participants