Ensure IMDServer sends EOF to client DURING test#5443
Conversation
Documentation build overview
5 files changed ·
|
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
The test_imd.py::test_imd_stream_empty test still fails:
FAILED testsuite/MDAnalysisTests/coordinates/test_imd.py::test_imd_stream_empty - Failed: Timeout (>200.0s) from pytest-timeout.
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
Looks like that some of the test cases never establish the connection and then they fail with
def disconnect(self):
> self.conn.shutdown(socket.SHUT_RD)
^^^^^^^^^^^^^^^^^^
E AttributeError: 'NoneType' object has no attribute 'shutdown'
|
Please |
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
Thanks, just the one question, but otherwise this seems like a reasonable fix.
| # Send the rest of the frames- small enough to all fit in socket itself | ||
| ref.server.send_frames(1, 5) | ||
| # Send EOF so the client does not rely on timeout to mark the end of the stream | ||
| ref.server.disconnect() |
There was a problem hiding this comment.
Just checking, is this because backward compatible or should we be adding a minimum pin?
There was a problem hiding this comment.
This should be backwards compatible. The disconnect call exists and is identical in the pinned version (0.2.2)
3 participants
Fixes #5442
Changes made in this Pull Request:
LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.