Skip to content

validate: the staleness probe must not make the file unreadable #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MDA2AV merged 1 commit into from
Aug 22, 2026
Merged

validate: the staleness probe must not make the file unreadable #1272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/validate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,12 @@ static_staleness_probe() {
# comparison can miss the change
cat "$file" > "$probe"
printf 'httparena-staleness-probe-%s\n' "$$" >> "$probe"
# mktemp creates 0600, and mv carries the source mode onto the destination.
# Left alone that makes the replacement unreadable to any container running
# as non-root, which reads back as "the server ignored the disk" -- a false
# failure for exactly the entries doing the right thing. Carry the mode of
# the file being replaced instead.
chmod --reference="$backup" "$probe"
original_sum="$(sha256sum "$backup" | cut -d' ' -f1)"
probe_sum="$(sha256sum "$probe" | cut -d' ' -f1)"

Expand Down