Repository navigation
docs(modules): define cleanup contract for a failed initialize - #2
Merged
Merged
Conversation
The manager closes a module's class loader when initialize throws but never calls shutdown, and nothing said so. A module that registered a listener before failing left it live; this was observed in Keystone on Paper 26.3. Document that cleanup after a failed initialize is the module's job and that shutdown only follows a successful start, on PluginModule, SimplePluginModule, README and AGENTS.md. Pin it with a test. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011DvdDwRoC7qHZ7yKUv1ufw
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manager closes a module's class loader when initialize throws but never calls shutdown, and nothing said so. A module that registered a listener before failing left it live; this was observed in Keystone on Paper 26.3.
Document that cleanup after a failed initialize is the module's job and that shutdown only follows a successful start, on PluginModule, SimplePluginModule, README and AGENTS.md. Pin it with a test.
Claude-Session: https://claude.ai/code/session_011DvdDwRoC7qHZ7yKUv1ufw