Repository navigation
Distrust compromised eMudhra intermediates - #226
Merged
Merged
Conversation
Jossec101
commented
Oct 21, 2026
Jossec101
commented
Collaborator
- Eight eMudhra intermediate CA keys leaked on 2026-10-20 (https://bugzilla.mozilla.org/show_bug.cgi?id=2083449)
- Anyone holding them can mint a TLS cert for any host, so outbound calls can be intercepted
- Go 1.26.10 rejects chains through those intermediates (CVE-2026-111943); older binaries keep trusting them until rebuilt
- Go 1.24 gets no fix, so bump the daemon go.mod and builder image to Go 1.26.10
- Eight eMudhra intermediate CA keys leaked on 2026-10-20 (https://bugzilla.mozilla.org/show_bug.cgi?id=2083449) - Anyone holding them can mint a TLS cert for any host, so outbound calls can be intercepted - Go 1.26.10 rejects chains through those intermediates (CVE-2026-111943); older binaries keep trusting them until rebuilt - Go 1.24 gets no fix, so bump the daemon go.mod and builder image to Go 1.26.10
- golangci-lint v1.64.8 is built with Go 1.24 and cannot load a Go 1.26 module - Migrate .golangci.yml with golangci-lint migrate and pin action v9.3.0 / v2.15.0 - Report only new issues: v2 flags 13 existing ones, left for a separate change
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The security-sensitive upgrade needs confirmation of the stated certificate-distrust fix and successful build, test, and lint checks.
No open issues 🎉
What changed in this PR
Updates the daemon’s Go toolchain to 1.26.10 to address the reported compromised eMudhra intermediates, alongside lint tooling changes.
Changes:
- Aligns the Go module and Docker builder images on Go 1.26.10.
- Migrates golangci-lint configuration to v2.
- Updates the lint action and limits reporting to new issues.
| File | Description |
|---|---|
daemon/go.mod |
Requires Go 1.26.10. |
daemon/docker/Dockerfile |
Updates the default builder image. |
daemon/.golangci.yml |
Migrates linter settings and exclusions to v2. |
.github/workflows/daemon.yaml |
Updates the builder image and lint tooling. |
Review effort: Balanced
RodriFS
approved these changes
Oct 27, 2026
imclvr
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.