Repository navigation
Hold the upload worker up for sure in the test that a frame waits for its uploads - #332
Merged
Merged
Conversation
… its uploads FrameWaitsForItsUploads queued an 8 MB copy, then a 300 ms sleep through UploadWorker::Then, and asserted the worker was busy. Then runs its job at once when the worker is idle, so on a fast machine the copy was done first, the sleep ran on the test's own thread, and the assertion failed (seen on the Linux clang CI job). - The hold-up sleeps only when it runs on the worker, and is queued again until it does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GpuReadbackTest.FrameWaitsForItsUploadsfailed on the Linux clang CI job for #331, at its setup check that the upload worker is busy. The same code passed on the other jobs, and on the run for main after the merge.Cause
UploadWorker::Then, and checks that the worker is busy.Thenruns its job at once, on the calling thread, when the worker is idle.Thenis called. The sleep then runs on the test's own thread, the worker is never held up, and the check fails.What changes
Validation
gui_gpu_testspasses; this PR changes only that program's test file.