Dashboard UI follow-up for ping metrics - #21
Open
Nini-50 wants to merge 2 commits into
Open
Conversation
- Add PingConstants with placeholder server address, ping count and timeout - Add _pingPacketLoss and _pingRttResult StateFlows to MainActivityViewModel - Call Ping.start() after MLab test and populate flows with real results - Reset ping state in resetMLabTestResult() - Use real packet loss value when saving ConnectivityReportModel - HomeScreen: collect ping flows and pass to ConnectivityCard - ConnectivityCard: accept packetLoss and pingRtt params; replace hardcoded '0 % loss' TODO: Replace PingConstants.PING_SERVER_ADDRESS with real server endpoint Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- restyle Home connectivity card to dashboard tile layout - add live/pending status pill and stronger metric hierarchy - set default ping endpoint constant to google.com:443 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
nini-50-task-2-udp-scaffold) so it only contains UI/dashboard changes.mainif needed.Testing
Screenshots