Repository navigation
Sync plugin logging contract - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
把 Lithe preview 合并提交
7a24126eca3a26775daeb84db38ae04bec938d1a(1lck/Lithe-IDEA#1699,插件与调试适配器接入结构化日志 v2)的插件契约同步到contract/v1,让插件开发者文档和已合并的 Rust Core 契约保持逐字节一致。改动
contract/v1/README.md:新增 “Structured plugin diagnostics (logging protocol 1)” 一节,内容包括:experimental.litheLogging中协商版本 1;lithe/log只接受operationFinished/operationFailed/degraded/recovered四种事实,以及允许的字段;operation可取的名称,包括lithe/keymap/import;contract/v1/fixtures/plugin-logging.json。contract.lock.json固定到上述 preview 提交,共 79 个文件。本 PR 合入后,再合入 SDK PR #17(三种 SDK 接入
litheLogging1)。验证
node scripts/contract.mjs sync --revision 7a24126eca3a26775daeb84db38ae04bec938d1a --checkout <Lithe checkout>node scripts/contract.mjs verify --upstream(79 个文件通过)node scripts/contract.mjs drift --ref preview:无漂移node --test scripts/*.test.mjs(16/16 通过)git diff --check