feat: Add Module:CharacterStats/Custom for omegastrikers wiki - #8012
Open
steve020607 wants to merge 2 commits into
Open
feat: Add Module:CharacterStats/Custom for omegastrikers wiki#8012steve020607 wants to merge 2 commits into
steve020607 wants to merge 2 commits into
Conversation
same code style as #7903
steve020607
changed the title
hjpalpha
reviewed
Aug 25, 2026
|
|
||
| ---@class CharacterStatsWidgetProps | ||
| ---@field characterSize string | ||
| ---@field characterSize string? |
Collaborator
There was a problem hiding this comment.
due to the default props this is never nil
Collaborator
Author
There was a problem hiding this comment.
But how to remove the error of previous commit?
Since there's no ?, the luals just think that it should set field on the custom version
And also most of the wiki is using this defaultProps, and nothing changes
| return Array.filter(teamBans, String.isNotEmpty) | ||
| end | ||
|
|
||
| return OmegaStrikersCharacterStats No newline at end of file |
Collaborator
Author
There was a problem hiding this comment.
Do you mean adding empty line on the last line after the return OmegaStrikersCharacterStats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
same code style as #7903
to changed the StrikerStats(custom made module)
How did you test this change?
Live(tested on my testing page)
https://liquipedia.net/omegastrikers/Module:CharacterStats/Custom
https://liquipedia.net/omegastrikers/User:Steve23