Repository navigation
Conversation
Follows the pattern from Liquid-co#19: one sentence per key, bold parts through segments() placeholders, counts through Intl.PluralRules. - home/ScanDialog, ScanFolderList, SetupGuide, LibraryGrid, LibraryTile, LibraryViewOptions, HomeSummary, AddGameCard, OfferedGames, RecentActivity - 146 new keys, grouped per component - a few generic strings land in common.* (cancel, nowTracking) so the same wording is not translated twice; duplicated existing keys reuse the originals (home.devices, home.scanning, home.chooseFolderDialog, home.welcome.scanForSaves) - Labels built in lib/ (cover styles, sort names, status text, time ago) are still English: they return words, not sentences, so they need their own pass to expose keys instead. Left out to keep this reviewable. - Windows example path in AddGameCard's placeholder stays as typed npm test: 271/271; vite build clean
|
Someone is attempting to deploy a commit to the sivadaboi's projects Team on Vercel. A member of the Team first needs to authorize it. |
504127b to
ecee29a
Compare
|
Rebased onto Clean rebase, no manual fixes needed: the only file the two histories share
I'll base the follow-up view PRs on |
ecee29a to
504127b
Compare
|
Correction to the note above — I tried it, and rebasing this branch onto The reason: this PR's base is So: the branch is back where it was (12 files, +525/−161, mergeable), and What I think you mean, and what I'll follow from here: subsequent view PRs go |
Follows the pattern from #19 and extracts the rest of the Home screen — the
ten child components under
views/home/.Included
ScanDialog,ScanFolderList,SetupGuideLibraryGrid,LibraryTile,LibraryViewOptionsHomeSummary,AddGameCard,OfferedGames,RecentActivityHome is now fully translated end to end (146 new keys; both catalogs at 167).
Conventions kept from the review in #19
branch, a path), it stays one key with a
{placeholder}rendered throughsegments()— three places here.Intl.PluralRules(home.scan.trackedGames,home.scan.foundInFolders,home.scan.oneSave,home.scan.foundSummary,home.tile.snapshots,home.library.bulkDone,home.offered.intro).home.scan.*,home.library.*, …).Two judgement calls, easy to change if you'd rather not
common.*group (common.cancel,common.nowTracking) instead oftranslating the same wording twice. Where a value already existed
(
home.devices,home.scanning,home.chooseFolderDialog,home.welcome.scanForSaves) I reused that key rather than adding aduplicate.
lib/are still English:libraryview.jscoverstyles and tile sizes,
gamestatus.jssort names and status text,timeago.js,syncpause.js. They return single words, not sentences, sothey need a pass that has them hand back keys for the component to render
— I left that out to keep this one reviewable. Say the word and I'll do it
as its own PR.
One thing left as typed on purpose: the Windows example path in
AddGameCard's placeholder (C:\Users\you\AppData\…) — translating it wouldmake it a worse example.
Checks
npm test: 271/271 (catalog completeness, placeholder parity, no missingor extra keys)
vite build: cleanHappy to rebase onto a newer
i18nwhenever you'd like — I noticedi18nisstill a few commits behind
dev(2.4.1) and didn't want to move it myself.