Skip to content

Track game: the games running now come first - #126

Merged
Omar-VF merged 2 commits into
Liquid-co:dev-publicfrom
ChakraFusion:pr/running-now
Oct 28, 2026
Merged

Omar-VF merged 2 commits into
Liquid-co:dev-publicfrom
ChakraFusion:pr/running-now

Conversation

@ChakraFusion

Copy link
Copy Markdown

The game being played is the one most often tracked, but "Track game" (#73) made it be searched for by name. The dialog now lists first, under Running now, the games the game database knows with a program running at this moment:

  • matched by where the program is installed (GameDB.IdentifyProgram, as for a program picked by hand);
  • each game once, however many of its programs run;
  • programs under %WINDIR% are left out;
  • a game already tracked says so, as in the search results.

Picking one tracks it with that program as the game's program. GET /api/gamedb/running; the new text is in the catalogs (en, zh-Hans, zh-Hant, the Chinese as a first attempt for @Janlhin to check).

Test: TestRunningGames_TheGamesTheDatabaseKnowsRunningNow (Windows): two programs of one known game are listed once, and a system program and an unknown tool aren't listed.

Checks: the full unit and e2e suites and the frontend tests pass locally on today's dev-public, and the frontend builds.

🤖 Generated with Claude Code

The game being played is the one most often tracked, and "Track game"
made it be searched for by name. It now lists first the games the game
database knows with a program running now, by where the program is
installed (GameDB.IdentifyProgram), once each, programs of the system
itself left out; picking one tracks it with that program. A game tracked
already says so, as in the search results. GET /api/gamedb/running; the
new text is in the catalogs (en, zh-Hans, zh-Hant).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 26, 2026

Copy link
Copy Markdown

@ChakraFusion is attempting to deploy a commit to the sivadaboi's projects Team on Vercel.

A member of the Team first needs to authorize it.

# Conflicts:
#	cmd/opensave-app/frontend/src/locales/zh-Hant.json
@Omar-VF

Omar-VF commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Thanks, this is a nice touch. We'd like to merge it. It now conflicts with #123 in zh-Hant.json, which changed the neighbouring Track game entries. Please rebase.

@ChakraFusion

Copy link
Copy Markdown
Author

Thanks! Done in 82bd382: today's dev-public is merged in, keeping #123's 跟蹤 for the title and adding the three Running now keys after it. GitHub shows it mergeable. I merged rather than rebased to keep the review history; happy to rebase instead if you prefer.

@Omar-VF
Omar-VF merged commit a0f6032 into Liquid-co:dev-public Oct 28, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants