[TENT] Add native UB transport with bonding fixes (rebased on latest main) - #40
Open
Connor-Matthew wants to merge 11 commits into
Open
[TENT] Add native UB transport with bonding fixes (rebased on latest main)#40Connor-Matthew wants to merge 11 commits into
Connor-Matthew wants to merge 11 commits into
Conversation
Avoid initializing underlying udmac* contexts alongside bonding_dev_0 by default, which can bypass UBAGG and cause cross-node LOC_ACCESS_ERR. Co-authored-by: Cursor <cursoragent@cursor.com>
Bring over the local working-tree fixes needed for bonding_dev_0: SET_BONDING_MODE, CTP priority/multi_path jetty config, and token_id segment registration. Also wire topology discover_ub from ub/enable. Co-authored-by: Cursor <cursoragent@cursor.com>
Reuse device_selection helpers in urma_adapter and install path so heuristics cannot drift, and always free token_id when unregister fails. Co-authored-by: Cursor <cursoragent@cursor.com>
Apply clang-format-20 to changed lines in ub_transport.cpp and urma_adapter.cpp so CI code format check passes. Co-authored-by: Cursor <cursoragent@cursor.com>
tebench --help exits 1 under gflags; tolerate that so the UB benchmark CLI smoke step checks help text instead of failing early under set -e. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve control_plane conflicts by keeping both official decodeBootstrapResponse (RDMA) and UB bootstrapUb APIs. Co-authored-by: Cursor <cursoragent@cursor.com>
Re-apply the ub-mock CLI help smoke test that was dropped while resolving the merge onto the latest LinQuick main. Co-authored-by: Cursor <cursoragent@cursor.com>
29 tasks
…nflight token, decouple Topology from UB enable - scanTimeouts(): after a successful quiesce fence, explicitly remove and release a still-present timed-out token before scheduling its retry. A provider-lost completion previously left the token in inflight_, so releaseInflight() never ran and endpoint outstanding/quota stayed charged until stop(), which could exhaust capacity and stall later transfers. - Topology::discover(): drop the transport-policy discover_ub flag and keep discovery transport-agnostic (always attempt UB when the platform supports it); UbTransport activation remains gated by transports/ub/enable in the transport loader. - Add regression test ProviderLostCompletionIsReclaimedAfterSuccessfulFence with a fake-adapter switch that makes quiesce succeed without returning the token, asserting inflight/quota/outstanding accounting return to zero and subsequent transfers still make progress. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…complete teardown - Add transports/ub/max_slices_per_task (default 64k) and reject requests whose slice count exceeds it in submitTransferTasks, bounding per-task memory/scheduling footprint. - EndpointStore: treat retire() as incomplete when the endpoint does not reach kDestroyed, quarantine it instead of replacing it, and retry getOrCreate() so a same-key endpoint is not reused while cleanup is still in progress. - Tests: fake adapter gains reset-failure injection; new EndpointStoreDoesNotReplaceEndpointWhenCleanupCannotComplete plus slice-cap rejection coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ub/bonding-device-selectiononto the latest LinQuickmain(synced with upstream).decodeBootstrapResponse(RDMA bootstrap validation) and UBbootstrapUbAPIs.mainfor CI.This PR is for CI only — do not merge.
Module
mooncake-transfer-engine)Type of Change
How Has This Been Tested?
Test results:
Checklist
control_planekeeps RDMA + UB paths)Made with Cursor