fix(processing): preserve checkpoint paths without UUIDs - #889
Draft
TimKoornstra wants to merge 1 commit into
Draft
fix(processing): preserve checkpoint paths without UUIDs#889TimKoornstra wants to merge 1 commit into
TimKoornstra wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #888. Checkpoint writers now produce stable filenames such as
checkpoint-0.json, butremove_uuid_from_filename()still removed the final 38 characters from every path under.checkpoints. This truncated the output prefix and wrote checkpoint objects outside their intended directory.This change only removes the suffix when the filename actually matches
checkpoint-<rank>-<32-character hexadecimal UUID>.json. Stable checkpoint filenames and unrelated files remain unchanged.Regression tests cover legacy UUID filenames, stable checkpoint names, configuration files, malformed UUID suffixes, and paths outside the checkpoint directory.
Validation:
8 passedintests/processing/test_utilities.pyPR review
Anyone in the community is free to review the PR once the tests have passed.
Did you have fun?
Yes 🙃