Repository navigation
Cover HTTPS access from worker networks - #153
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add integration coverage for accessing the shared HTTPS proxy from a worker container through the worker's canonical hostname.
Why
LibreSign's Dev Container integration exposed a gap in the proxy test suite: host-loopback HTTPS was covered, but worker-network HTTPS was not.
The regression test now verifies both TCP ports 80/443 and a real HTTPS request through:
The test confirmed that the current proxy implementation supports this path. The failure observed in LibreSign came from starting its optional Playwright runner and probing the proxy immediately; LibreSign now starts the runner explicitly and waits/retries through a real Chromium smoke test.
This PR therefore adds the missing NCDD regression coverage without changing runtime behavior.