Skip to content

Add Docker image publish workflow - #7

Open
henmohr wants to merge 2 commits into
mainfrom
feature/add-workflow
Open

henmohr wants to merge 2 commits into
mainfrom
feature/add-workflow

Conversation

@henmohr

@henmohr henmohr commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a GitHub Actions workflow to build and publish the Kimai PHP image to GHCR
  • pass VERSION=2.6.0-prod to the Docker build
  • add a Dockerfile default for VERSION so local builds do not resolve kimai/kimai2:fpm-

Validation

  • docker build --progress=plain --build-arg VERSION=2.6.0-prod -f .docker/php/Dockerfile .docker/php
  • git diff --check

Note: GitHub only allows workflow_dispatch for workflows present on the default branch, so this new workflow will publish after it is merged into main.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-15T16:59:13.650780Z 00b4fc7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@henmohr
henmohr requested a review from YvesCesar September 15, 2026 16:59

@vitormattos vitormattos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we add a workflow to publish this image, I think we need to review why we still have a custom image.

Kimai already provides separate official images for production and development. kimai/kimai2:dev is specifically intended for local development, while the regular images are intended for production.

Our current Dockerfile seems to reproduce development concerns such as Xdebug, source code in a volume and a custom entrypoint. So instead of creating our own development and production tags, I think we should first check if we can replace this setup with the official Kimai images.

If the official dev image covers our development needs and the official production image covers production, we probably don't need this publish workflow or even this Dockerfile.

@henmohr

henmohr commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Indeed. Maybe it's time to archieve this repo.

Current documentation of kimai is pretty good.

@vitormattos

Copy link
Copy Markdown
Member

Could be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants