Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
vitormattos
left a comment
There was a problem hiding this comment.
Before we add a workflow to publish this image, I think we need to review why we still have a custom image.
Kimai already provides separate official images for production and development. kimai/kimai2:dev is specifically intended for local development, while the regular images are intended for production.
Our current Dockerfile seems to reproduce development concerns such as Xdebug, source code in a volume and a custom entrypoint. So instead of creating our own development and production tags, I think we should first check if we can replace this setup with the official Kimai images.
If the official dev image covers our development needs and the official production image covers production, we probably don't need this publish workflow or even this Dockerfile.
|
Indeed. Maybe it's time to archieve this repo. Current documentation of kimai is pretty good. |
|
Could be. |
Summary
Validation
Note: GitHub only allows workflow_dispatch for workflows present on the default branch, so this new workflow will publish after it is merged into main.