Skip to content

fix: render nightly release notes safely #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 2 commits into from
Sep 22, 2026
Merged

fix: render nightly release notes safely #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68d5a94
fix: render nightly release notes without shell substitution
vitormattos Sep 22, 2026
ae5bd1a
test: assert literal nightly Markdown backticks
vitormattos Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/test_nightly_release_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ def test_nightly_runs_full_package_and_publication_path(self) -> None:
self.assertIn("gh release create nightly", content)
self.assertIn("nextcloud-libraries/nextcloud-appstore-push-action@", content)
self.assertIn("nightly: true", content)
self.assertIn("printf 'Automated nightly build from `%s`.", content)
self.assertIn("printf 'Generated from commit `%s`.", content)

def test_checkout_credentials_are_not_persisted(self) -> None:
content = TEMPLATE.read_text(encoding="utf-8")
Expand Down
4 changes: 2 additions & 2 deletions workflow-templates/nightly-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ jobs:
{
echo "## 🌙 Nightly Build - ${APP_VERSION}"
echo
echo "Automated nightly build from `${NIGHTLY_BRANCH}`."
printf 'Automated nightly build from `%s`.\\n' "${NIGHTLY_BRANCH}"
echo
echo "⚠️ **Development version** - may contain bugs or unstable features."
echo
Expand All @@ -260,7 +260,7 @@ jobs:
printf '%s\n' "${commits}"
echo
echo "---"
echo "Generated from commit `${GITHUB_SHA:0:7}`."
printf 'Generated from commit `%s`.\\n' "${GITHUB_SHA:0:7}"
} > release-notes.md

- name: Create or update GitHub release
Expand Down
Loading