Skip to content

Get rid of some repository variables #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
colisee wants to merge 7 commits into from
Closed

Get rid of some repository variables #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fef95e4
Switch to "$/" path style
colisee Oct 19, 2026
6b7f62c
Get latest image release programmatically
colisee Oct 19, 2026
c5d8071
Fix action
colisee Oct 19, 2026
63f9e9e
Fix action path
colisee Oct 19, 2026
641fbee
Extend modifications to build_image_release.yml
colisee Oct 19, 2026
88f8104
Use versioned github action
colisee Oct 19, 2026
19ac180
Use versioned github action
colisee Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/build_image_develop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,23 @@ on:
workflow_dispatch:

jobs:
get-data:
runs-on: ubuntu-latest
outputs:
releaseImg: ${{ steps.get_release_img.outputs.release }}
steps:
-
id: get_release_img
uses: pozetroninc/github-action-get-latest-release@v0.8.0
with:
repository: ${{ github.repository }}
build-develop:
uses: ./.github/workflows/build_and_publish.yml
needs: get-data
uses: $/.github/workflows/build_and_publish.yml

@JohnVillalovos JohnVillalovos Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that this $ syntax is valid?

@colisee colisee Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the $/ syntax is valid, as indicated here

with:
appGitRefs: develop
appAddSha: true
imgBuild: ${{ vars.VERSION_LB_IMG }}
imgBuild: ${{ needs.get-data.outputs.releaseImg }}
regName: ${{ vars.REGISTRY_URL }}
regLogin: ${{ vars.REGISTRY_LOGIN }}
secrets:
Expand Down
23 changes: 20 additions & 3 deletions .github/workflows/build_image_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,29 @@ on:
workflow_dispatch:

jobs:
get-data:
runs-on: ubuntu-latest
outputs:
releaseImg: ${{ steps.get_release_img.outputs.release }}
releaseApp: ${{ steps.get_release_app.outputs.release }}
steps:
-
id: get_release_img
uses: pozetroninc/github-action-get-latest-release@v0.8.0
with:
repository: ${{ github.repository }}
-
id: get_release_app
uses: pozetroninc/github-action-get-latest-release@v0.8.0
with:
repository: librebooking/librebooking
build-stable:
uses: ./.github/workflows/build_and_publish.yml
needs: get-data
uses: $/.github/workflows/build_and_publish.yml
with:
appGitRefs: ${{ vars.VERSION_LB_APP }}
appGitRefs: ${{ needs.get-data.outputs.releaseApp }}
appAddSha: false
imgBuild: ${{ vars.VERSION_LB_IMG }}
imgBuild: ${{ needs.get-data.outputs.releaseImg }}
regName: ${{ vars.REGISTRY_URL }}
regLogin: ${{ vars.REGISTRY_LOGIN }}
secrets:
Expand Down
Loading