fpu: canonicalize NaN results of fadd/fmul/fdiv and fused ops - #259
Open
carlosqwqqwq wants to merge 1 commit into
Open
fpu: canonicalize NaN results of fadd/fmul/fdiv and fused ops#259carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
Owner
|
@SolAstrius please confirm via your out-of-tree test suite and review if possible, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The FP writeback for
fadd,fmul,fdivand the fusedfmadd/fmsub/fnmsub/fnmaddfamily stores the raw host result, which keeps non-canonical NaN payloads. Thefsub/fmin/fmaxpaths already canonicalize through the write helpers; the RISC-V specification requires the canonical NaN bit pattern for arithmetic results. Route the remaining arithmetic writebacks through the same canonicalizing writers.Signaling-NaN
NVflagging is unchanged.Validation
inf*0+1and0/0probes match native RISC-V hardware and QEMU after the fix, with the JIT enabled and disabled.fflagsmatch the references.Fixes #254