Skip to content

test(scheduledauth): tolerate go-oidc's in-flight JWKS reuse in the failed-refresh test #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Oct 20, 2026
Merged

test(scheduledauth): tolerate go-oidc's in-flight JWKS reuse in the failed-refresh test #1231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions internal/server/scheduledauth/kidguard_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,20 @@ func TestValidate_OIDC_FailedRefreshDoesNotCacheKid(t *testing.T) {
failing.Store(true)
bad := signedFor(t, keyX, t0)
for i := 0; i < 3; i++ {
// go-oidc's keysFromRemote marks the in-flight fetch done before it
// clears r.inflight (jwks.go:196-234), so a back-to-back Validate can
// reuse the finished fetch without a new request. Retry until one
// fetch happens; every call must still fail closed.
before := hits.Load()
if err := v.Validate(context.Background(), bad); !errors.Is(err, ErrUnauthorized) {
t.Fatalf("token %d: expected ErrUnauthorized, got %v", i, err)
}
if hits.Load() == before {
t.Fatalf("token %d: no JWKS fetch although no refresh ever confirmed the kid unknown", i)
deadline := time.Now().Add(2 * time.Second)
for hits.Load() == before {
if err := v.Validate(context.Background(), bad); !errors.Is(err, ErrUnauthorized) {
t.Fatalf("token %d: expected ErrUnauthorized, got %v", i, err)
}
if time.Now().After(deadline) {
t.Fatalf("token %d: no JWKS fetch within 2s although no refresh ever confirmed the kid unknown", i)
}
time.Sleep(5 * time.Millisecond)
}
}
if n := negativeKidCount(v); n != 0 {
Expand Down
Loading