Skip to content

fix(frontend): don't offer Exchange for reshape rows with no target #1410

Closed

Description

@cristim

On the RI-exchange reshape page, frontend/src/riexchange.ts ~985/990 renders a recommendation with no target as "0x " and still shows a live Exchange button. With the cloud-commitments-go bump in #1246 (go#584 offered instance types, and 0dd6bde capping reshape targets at owned units), more recommendations legitimately come back with no target, so this shows up more often.

Fix: render no-target rows with their Reason (or a clear "no exchange target available" message), disable or hide the Exchange button for them, and add a jest test. Found in an independent review of #1246.

Activity

  1. IAmJSD commented on Oct 26, 2026

    @IAmJSD
    Collaborator

    Claiming: working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions