Repository navigation
chore(lint): drop monorepo path exclusions from .golangci.yml - #110
Merged
Merged
Conversation
Removes the exclusions for internal/, pkg/ and cmd/configure_* paths and generated files, none of which exist in this repo. make lint still reports 0 issues. Part of #2 (item 7; .gitallowed and .gitleaks.toml already carry no internal/ entries). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
Merge gate verdict (claude-cc-libs)Every gate holds at head e320b46:
CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2 (item 7)
.golangci.ymlstill excluded monorepo paths that do not exist here:internal/testutil/,internal/api/,pkg/ladder,internal/config,cmd/configure_gcp|azureand*_gen.go. This removes them and keeps the only rules that match real files (_test.go).Verified on origin/main:
.gitallowedalready holds onlyscripts/andtools/entries, and there is no.gitleaksignore;.gitleaks.tomlhas nointernal/paths. Nothing to prune there.Evidence:
make lintreports 0 issues;go test -count=1 ./...passes.🤖 Generated with Claude Code
Summary by CodeRabbit