Skip to content

chore(lint): drop monorepo path exclusions from .golangci.yml - #110

Merged
cristim merged 2 commits into
mainfrom
chore/2-prune-golangci-monorepo-paths
Oct 20, 2026
Merged

cristim merged 2 commits into
mainfrom
chore/2-prune-golangci-monorepo-paths

Conversation

@cristim

@cristim cristim commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Part of #2 (item 7)

.golangci.yml still excluded monorepo paths that do not exist here: internal/testutil/, internal/api/, pkg/ladder, internal/config, cmd/configure_gcp|azure and *_gen.go. This removes them and keeps the only rules that match real files (_test.go).

Verified on origin/main: .gitallowed already holds only scripts/ and tools/ entries, and there is no .gitleaksignore; .gitleaks.toml has no internal/ paths. Nothing to prune there.

Evidence: make lint reports 0 issues; go test -count=1 ./... passes.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated linting exclusions to retain only the test-helper exception for background context usage.
    • Removed several source, generated-file, API, command, and spelling-related linting exemptions.

Removes the exclusions for internal/, pkg/ and cmd/configure_* paths and generated files, none of which exist in this repo. make lint still reports 0 issues. Part of #2 (item 7; .gitallowed and .gitleaks.toml already carry no internal/ entries).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-mcp/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: bd30e3fc-0923-4411-9693-35da7178d253
📥 Commits

Reviewing files that changed from the base of the PR and between db465cd and e320b46.

📒 Files selected for processing: 1
  • .golangci.yml
💤 Files with no reviewable changes: 1
  • .golangci.yml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📝 Walkthrough

The linter configuration removes exclusions for several paths and rules. It retains a noctx exemption for _test.go files.

Changes: Linter configuration

Layer / File(s) Summary
Update linter exclusions
.golangci.yml
The configuration retains a noctx exclusion for _test.go files and removes exclusions for internal/testutil, generated files, an internal/api revive warning, configure-command noctx, and specified misspell cases.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to e320b

This change tightens the lint configuration and does not alter runtime behavior. No merge-blocking risk is evident.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing monorepo path exclusions from .golangci.yml.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Merge gate verdict (claude-cc-libs)

Every gate holds at head e320b46:

  • Two independent reviews approve the reviewed head 094f032. The branch was then updated from main, and the PR diff is byte-identical to the reviewed diff (compared mechanically).
  • CI is green on e320b46, which is the reviewed change on top of current main.
  • 0 unresolved threads; MERGEABLE/CLEAN.

CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging.

@cristim
cristim merged commit fec4dd3 into main Oct 20, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant