[cristim]

Summary

Test-only. In providers/aws/ladder/ce_loopback_body_test.go, TestCELoopbackPublicBaselineAfterBodyClose's cleanup joined the handler and the wrote channel unconditionally. When the request aborted before any connection was dialed (a dial failure, or the guard rejecting before the request), neither ever completed, so cleanup waited out both 5s bounds and buried the real error under two extra "schedule did not complete" errors.

• ceSchedule gains dialed (set in DialContext on success) and handlerStarted (set at handler entry).
• Cleanup joins the handler only if it started and wrote only if a connection was dialed; otherwise it logs "request aborted before any connection was dialed; skipping write and handler joins". The primary error is kept; the success path is unchanged; every remaining wait still goes through the 5s-bounded ceAwait. A handler cannot start without a dialed connection, and srv.Close() still waits for any in-flight handler.

Closes #417

Evidence

• Probe (scratch copy): an injected dial failure took 10.01s and produced two extra join errors with the old cleanup; with this change it takes 0.00s and reports only the primary error plus the skip line.
• go test -race -count=20 -run TestCELoopbackPublicBaselineAfterBodyClose: ok.
• make build, make vet, (cd providers/aws && GOWORK=off go test -race -short ./ladder/...), pinned golangci-lint v2.10.1 (0 issues), gofmt, and the commit/pre-push hooks pass.

Local review: non-author review of the 15-line diff (join conditions, the wrote close path at the request-write trace, and handler shutdown), no findings.

🤖 Generated with Claude Code

[cristim]

@coderabbitai review

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 1 billable file and costs up to $0.25.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 17 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 72 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: LeanerCloud/cloud-commitments-go/.coderabbit.yaml
• Review profile: CHILL
• Plan: Essentials
• Run ID: 66dbe942-998d-47f2-ad70-e01bbb341758

📥 Commits

Reviewing files that changed from the base of the PR and between b2d8e6b and 64012d6.

📒 Files selected for processing: 1

• providers/aws/ladder/ce_loopback_body_test.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[cristim]

Independent review verdict: CLEAN at 64012d6

Reviewer: fresh Claude agent (Sonnet, high effort), not the author, cold brief. Coordinator: claude-cc-reviewer.

Blocking findings: none. This is a test-only change to providers/aws/ladder/ce_loopback_body_test.go.

• The skipped joins are safe:
  • If the handler never started, handlerJoin stays nil and srv.Close() runs. httptest.Server.Close waits for outstanding connections, so the later handlerErr assertion is still sound.
  • The write join is skipped only when nothing was dialed, so no write can have happened and no writeErr is hidden. When a connection was dialed, s.wrote is still awaited.
  • The writeErr, sdkClosed, entered, copyErr, status and baseline assertions are unchanged.
• test(aws): distinguish pre-write aborts during fixture cleanup #417's body-close/EOF behaviour is untouched: only the abort-path joins changed, and the happy path is identical.
• Stability:
  • go test -race -count=200 -run TestCELoopbackPublicBaselineAfterBodyClose ./ladder/: 200 passed, 0 failed (~6.5s).
  • go vet ./ladder/... is clean, and go test -race -count=1 ./ladder/... passes 268.

Gate: p3, labels on the PR. Merge once CI is green. (claude-cc-reviewer)