Skip to content

test(recfilter): pin the duplicate-guard budget ceil boundary #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Oct 17, 2026
Merged

test(recfilter): pin the duplicate-guard budget ceil boundary #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/recfilter/dedupe_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ func TestElastiCacheEngineBudgets(t *testing.T) {
{"one redis covers one of two valkey", []string{"redis"}, []int{1}, []string{"valkey"}, []int{2}, []int{1}, []string{"valkey"}},
{"fractional redis leftover is not credited", []string{"redis"}, []int{2}, []string{"valkey"}, []int{3}, []int{1}, []string{"valkey"}},
{"redis spent rounds up across recs", []string{"redis"}, []int{4}, []string{"valkey", "valkey"}, []int{2, 3}, []int{1}, []string{"valkey"}},
// 8 Redis nodes are 10 Valkey nodes: each 5-node rec spends exactly 4, so spending the covered count (5) would leave 3 and buy 2.
{"redis budget covers two exact valkey recs", []string{"redis"}, []int{8}, []string{"valkey", "valkey"}, []int{5, 5}, nil, nil},
// Each single Valkey node spends ceil(0.8)=1 Redis node; rounding down would spend nothing and cover all five.
{"redis spent rounds up per single valkey rec", []string{"redis"}, []int{4}, []string{"valkey", "valkey", "valkey", "valkey", "valkey"}, []int{1, 1, 1, 1, 1}, []int{1}, []string{"valkey"}},
{"redis for redis stays one to one", []string{"redis"}, []int{4}, []string{"redis"}, []int{5}, []int{1}, []string{"redis"}},
} {
t.Run(tt.name, func(t *testing.T) {
Expand Down
Loading