Skip to content

ci: make gocyclo gating and document why Snyk is not #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Oct 19, 2026
Merged

ci: make gocyclo gating and document why Snyk is not #2279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,13 @@ jobs:
# Exclude _test.go files to stay consistent with .golangci.yml, which
# excludes gocyclo on test files (test helpers/table-driven tests are
# allowed higher complexity). Production code is still gated at >10.
COMPLEXITY_ISSUES=$(gocyclo -over 10 -ignore "_test\.go" . 2>&1 || true)
if [ -n "$COMPLEXITY_ISSUES" ]; then
echo "❌ Found functions with cyclomatic complexity over 10:"
# No `|| true`: a non-zero exit (offenders, crash, missing binary) fails
# the step. gocyclo exits 0 on a bad path (error on stderr), so any
# output also fails; a clean run prints nothing.
RC=0
COMPLEXITY_ISSUES=$(gocyclo -over 10 -ignore "_test\.go" . 2>&1) || RC=$?
if [ "$RC" -ne 0 ] || [ -n "$COMPLEXITY_ISSUES" ]; then
echo "❌ gocyclo failed or found functions with cyclomatic complexity over 10:"
echo "$COMPLEXITY_ISSUES"
echo ""
echo "⚠️ Please refactor these functions to reduce complexity."
Expand Down Expand Up @@ -439,6 +443,8 @@ jobs:
with:
go-version-file: go.mod

# Non-gating on purpose: Snyk is an external service, so its outages or
# rate limits must not block merges.
- name: Run Snyk to check for vulnerabilities
uses: snyk/actions/golang@b98d498629f1c368650224d6d212bf7dfa89e4bf # 0.4.0
continue-on-error: true
Expand Down
Loading