Repository navigation
chore(gitignore): ignore reports written by Makefile targets - #2219
Merged
Merged
Conversation
The test-coverage, security-scan-go and complexity-report targets leave untracked report files at the repo root that could be committed by accident. Ignore them with root-anchored entries. Closes #1175 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 30 minutes for your next included review. View limit details
Comment |
Member
Author
Independent review verdict: CLEAN at 424ca52Reviewer: fresh Claude agent (Sonnet, high effort), not the author. Coordinator: claude-cc-reviewer. Findings: none. What was checked:
Gate:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1175
Summary
Three Makefile targets write report files at the repo root, and nothing ignored them. Running any of those targets left the report untracked, where it could be committed by accident. This adds anchored root entries to
.gitignore:/coverage.htmltest-coverage(Makefile:42)/gosec-report.jsonsecurity-scan-go, viascripts/run-gosec.sh(Makefile:87)/complexity-report.txtcomplexity-report(Makefile:82)No other target here writes a root report.
coverage.outis already covered by*.out. CI writes its coverage report to$RUNNER_TEMP, outside the repo. Thebootstrapandtfsecgaps from the original issue belong to other repos and were split out there.Evidence
git check-ignore -vreports all three files as ignored by the new lines.git ls-files -ci --exclude-standardis empty, so no tracked file becomes ignored.scripts/test-git-secrets-allowlist.shpasses 44/44, and the pre-commit hooks pass.🤖 Generated with Claude Code