Skip to content

fix(cmd): dry run accepts an EC2 Instance Savings Plan the real run refuses when InstanceFamily is unset #2164

Closed

Description

@cristim

validatePurchasePreconditions (added in #2160) requires only Details.Region for an EC2 Instance Savings Plan. With InstanceFamily unset and OfferingID empty, the real run can refuse in lookupEC2OfferingIDStrict (savingsplans/client.go:529-543: ambiguous or no offerings) while the dry run reports success. Require InstanceFamily unless OfferingID is set. Note the recommendation-completeness test fixture has no family and will need one.

Activity

  1. self-assigned this
    on Oct 17, 2026
  2. cristim commented on Oct 17, 2026

    @cristim
    MemberAuthor

    Claiming: working on this [claude-cli-impl]

  3. added a commit that references this issue on Oct 17, 2026
    b8ecf51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions