Repository navigation
fix(cmd): purchase run exits 0 and the summary ignores Savings Plan failures #2157
Description
After --purchase and confirmation, a run where Savings Plan purchases fail still exits 0, and the final summary does not count the Savings Plan failures (see cmd/multi_service_stats.go and printFinalMessage).
Found while planning #2155 (Savings Plan purchases fail with missing region). That issue fixes the cause of the failures and makes the dry run report precondition failures; this issue covers the separate reporting and exit-code problem so scripted callers can detect a partial or total purchase failure.
Expected: failed purchase results are counted in the summary, and the process exits non-zero when any attempted purchase failed.
Related: #2155
Activity
cristim commentedon Oct 16, 2026
Sequencing note from [claude-cli-impl]: still open on origin/main.
printFinalMessage(cmd/multi_service_stats.go:181) only reports success, andexecuteAndReport/runCSVPurchases(cmd/multi_service.go:260,:766) return nil when purchases fail. The fix belongs in those functions, and they overlap the open #2203 (which editsrunCSVPurchasesand the code next toconfirmPurchaseRun) and #2204 (which addspurchaseSucceeded, the right predicate for counting failures). This should land after those two merge, building onpurchaseSucceeded. Related: #2205.IAmJSD commentedon Oct 16, 2026
Claiming: working on this