[Repo] Fix build config duplicate, CI format gate, outdated docs - #234
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Three small, independent fixes surfaced by the repository code review:
src/DockerUpdateGuard/DockerUpdateGuard.csprojdeclaredGenerateDocumentationFiletwice; the duplicate is removed.ci.ymlnorrelease.ymlverified formatting, even thoughreihitsu-format ./is documented as a mandatory step. Both workflows now runreihitsu-format --check .after restore, so formatting drift fails the build. A pre-existing formatting drift inUpdateDetectionService.csis corrected alongside so the new gate starts clean..github/copilot-instructions.mdstill described the repository as an empty solution skeleton and referenced an unrelated project (SeriesOverwatch) for the EF Core migration convention. Both are updated to reflect the current, fully implemented state and the project's own migration history.🎫 Issues
Closes #92
Closes #90
Closes #88
👩💻 Reviewer Notes
The
DockerUpdateGuard.csprojchange is a pure duplicate-line removal. The optional secondary recommendation in #92 (a fixedAssemblyVersioninstead of the1.3.*wildcard, to allowDeterministic=true) is intentionally left out of this PR — it touchesSharedAssemblyInfo.cs, which is linked into every project, and is a versioning-policy decision rather than a bug fix; see Next Steps.📑 Test Plan
Locally:
dotnet restore,dotnet build -c Release, and the full MSTest suite (473 tests inDockerUpdateGuard.Tests, 21 inDockerUpdateGuard.Data.Tests) all pass. The new formatting gate was validated against the current tree and reports no drift.✅ Checklist
General
⏭ Next Steps
AssemblyVersion("1.3.*")inSharedAssemblyInfo.cswith a fixed version soDeterministiccan be left at its default (true) across all projects, per the optional recommendation in F-039 (P8) —DockerUpdateGuard.csproj: duplicate property & non-deterministic release build #92.