Repository navigation
Declare loop indexes in the for statement - #29
Merged
Merged
Conversation
C99 allows it, and C99 is the oldest standard CI tests. Only plain functions are converted. In a protothread function a for-declared index is an ordinary local, lost across a block, like any other. Variables still used outside their loops keep their declarations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SR7v9BVsFrHiEhQBSqZmAs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves loop index declarations into the
forstatement,for (int i = 0; ...), in plain (non-protothread) functions. That's three loops inprotothread.hand most of the test file's setup and check loops. C99 allows it, and C99 is the oldest standard CI tests.Protothread functions are left alone. A for-declared index there is still an ordinary local, lost across a block. Variables used outside their loops keep their declarations.
Based on #28, since it touches that PR's new tests. GitHub should retarget it to master once #28 is merged.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SR7v9BVsFrHiEhQBSqZmAs