Repository navigation
docs: the virtual crate serves property names as deposited and hides files not held - #79
Merged
Merged
Conversation
Records the decisions from #69. The virtual crate renames LDaC and PCDM properties to their prefixed forms and marks files the repository doesn't hold with display: false. The deposited crate is never changed. Adds virtual crate, metadata-only crate and shared entity to the glossary.
This was referenced Nov 17, 2026
The virtual crate no longer renames the older context-only spellings (communicationMode, memberOf), and the indexer reads only the prefixed forms. Updating an older crate is its owner's job.
johnf
marked this pull request as ready for review
November 17, 2026 02:15
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records two decisions from the indexer redesign ticket "What the indexer derives from a crate" (#69) in the domain docs. Docs only; no code changes.
What changes
display: false, which Oni reads to hide the preview and download.ldac:communicationMode,pcdm:memberOf); the indexer reads only that form and the virtual crate doesn't rename the older one (communicationMode,memberOf). Updating an older crate is its owner's job.An earlier version of this PR had the virtual crate rewritten to the prefixed spellings. That decision was reversed on 2026-11-17; the second commit carries the change.
Before merging
The ADR describes the design the indexer redesign (map: #65) is heading to, not what
maindoes today: the indexer still reads both spellings (valuesinsrc/indexer/search.ts,memberOfinsrc/indexer/indexer.ts,pickSingleMemberOfinsrc/indexer/database.ts), the test crates undertest-data/still use the oldercommunicationModeandindexableText, andentityAsCratedoesn't setdisplayyet. Merge this with the implementation, or earlier if you're happy for the ADR to lead the code.The full decision, with what was rejected and why, is in the resolution comment on #69.