Repository navigation
feat(zones): size zones in px or cm, with Session Review's scale - #243
Merged
Merged
Conversation
The zone editor's fixed size gets a px/cm picker; cm is enabled once a calibration can convert it, and the choice is remembered. Session Review now hands the editor the session's arena, else its px/mm, so zones drawn on a recorded video can be sized in centimetres. The Information box shows the scale in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FrameScale, else none (px only).Testing
test_zone_dialog_move_and_size.pyandtest_analysis_window.py; ruff and black clean.tests/unit/gui+tests/unit/vision: 3479 passed, 1 failed —test_every_pi_section_fits_480, which fails identically onmain(the metadata section is 486 px). The compact zone editor measures 412 px.