Repository navigation
fix(review): open a folder of Batch Pose videos as a cohort - #241
Merged
Merged
Conversation
A folder of videos run through Batch Pose holds no recording and no ethogram, so Open recording folder reported nothing to open and Open folder as cohort found no sessions. A video beside its DLC pose CSV is now a cohort session, like a pup-tracked video, unless an ethogram, pup session or the recording that filmed it already shows it. Open recording folder on a folder that is not one recording opens every session in it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A folder of videos run through Batch Pose (each video beside its
…DLC_<model>.csv,_rawcompanion and_zonesfolder) could not be opened in Session Review:_pups.npzbeside it.Fix
discover_sessionsnow treats a video as a session whenfind_pose_csvfinds its pose CSV, the same way pup-tracked videos already work. A video that already has a session is skipped so it is not listed twice: an ethogram scored from it, its pup session, or the GLIDER recording that filmed it (whose tracking the recording session already reads). Behaviour for existing cohorts is unchanged.open_path: when a folder is not one recording and does not hold exactly one ethogram, it now opens every session it finds as a cohort, instead of showing the error. The error still appears when nothing is found, or when the folder is a recording that failed to load.Verification
test_a_video_tracked_by_batch_pose_is_a_session,test_a_pose_tracked_video_with_another_session_is_not_listed_twice, andTestOpenVideo::test_a_folder_of_pose_tracked_videos_opens_them_all.tests/unit/analysisandtests/unit/gui/behavior: 2183 passed. ruff and black are clean.DLC_train-18.csvand its full length (675–695 s).