Repository navigation
feat(updater): offer updates from main, not tagged releases - #238
Merged
Merged
Conversation
A git checkout is now compared with GitHub's main branch at launch; if main is ahead, the dialog lists the new commits and Update now runs git pull --ff-only. A diverged or dirty checkout is refused, never merged. A pull that changes pyproject.toml or uv.lock says to re-run the installer. Prebuilt apps have no checkout and still check Releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The updater only looked at GitHub Releases, and the latest is still v1.0.0, so a checkout many commits behind
mainwas told it was up to date. We ship frommainrather than from tags.What
mainis ahead of the localHEAD. If it's ahead, the dialog says "N new changes on main since your copy", lists the newest commit titles, and offers Update now, which runsgit pull --ff-only origin main.pyproject.tomloruv.locktells the user to re-run the installer. It doesn't reinstall dependencies itself, because the installer's extras aren't recorded..git): still checks Releases, as before.HEADthat GitHub doesn't know (an unpushed commit) gets a 404 from the compare API, so the check stays quiet.Testing
pull_mainagainst a local throwaway origin (fast-forward, dependency flag, refusing a diverged checkout).test_updater.pyandtest_first_run.pypass (50 tests); ruff and black are clean.mainreports 0 behind, ande5fac47reports 31 behind with the correct commit list.