1223: Warn when web and database server time differ#7815
Merged
Conversation
labkey-adam
approved these changes
Jul 8, 2026
labkey-adam
reviewed
Jul 8, 2026
labkey-adam
reviewed
Jul 8, 2026
| _incrementalUpdateDisabled = deltaSeconds > thresholdSeconds; | ||
| DbScope scope = DbScope.getLabKeyScope(); | ||
| SqlDialect.ServerDatabaseTimeDifference difference = SqlDialect.getServerDatabaseTimeDifference(scope); | ||
| _incrementalUpdateDisabled = difference.exceedsWarningThreshold(); |
Contributor
There was a problem hiding this comment.
Only way to reset this is to restart that web server, right?
Contributor
Author
There was a problem hiding this comment.
Yes. This check is run often. Hopefully, the times being different is a rare occurrence and something that should be addressed.
labkey-nicka
force-pushed
the
26.7_fb_time_diff_1223
branch
from
d2fcdb2 to
a0032b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses #1223 by adding a configuration warning when the web server and database server times differ.
Related Pull Requests
Changes
SqlDialect.getServerDatabaseTimeDifference()to centralize logic for checking time differenceServerDatabaseTimeDifferencerecordunsafe()