Repository navigation
ci: the cgroup meter step takes yaml-cpp from the image its binary was linked in - #1780
Merged
Merged
Conversation
…s linked in The step runs pace-node-tests on the host, under the host's systemd scope, but the binary is linked in the shared CI image against the image's shared yaml-cpp. Since the host apt install became native-legs-only (#1775) the host has no libyaml-cpp, so the step died in the loader with exit 127 and Linux-clang-release has been red on master since, taking the four smoke jobs that download its artifact with it. The library is now copied out of the image and handed to the scope through LD_LIBRARY_PATH, and anything else the host cannot resolve is named before the run. Refs #1777 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01No1NznPsprjj92Cb5X6kkQ Signed-off-by: Yaraslau Tamashevich <yaraslau.tamashevich@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Linux-clang-releasehas been red onmastersince #1775, and every open pull request inherits it. The four smoke jobs fail with it, because they download thepace-linuxartifact that leg never gets to upload.The step "Test the compile-memory meter in a delegated cgroup" is the one step of an image leg that runs a built binary on the host (the scope is the host's systemd). The binary is linked in the shared CI image against the image's shared yaml-cpp. #1775 made the host apt install native-legs-only, so the host no longer has
libyaml-cpp.so.0.8:Fix
ci-imagecontainer (the copy the binary was linked against) and hands it to the scope throughLD_LIBRARY_PATH.lddwhat is still unresolved and fails naming all of it, rather than one library per run from the loader.Testing
check-workflow-step-env.sh,check-workflow-script-invocations.sh,check-workflow-walk-sole.sh.Linux-clang-releaserun is the test.Not addressed here
ci-apt-update.shrefuses on runner image20261111.127.1and passes on20261111.370.1in the same workflow run, so native Linux legs fail depending on which image a job draws (master: "compile-cache E2E (Linux)" failed and nobody was told #1776). That looks like GitHub's rollout and is left alone.Windows-cl-release-arm64failed a different test on each of the last two runs (node-scratch-isolation-e2eSEGFAULT onmaster,script-modeson fix(pace-cc): clang-cl dispatch keeps its macro context; refuse what the key cannot see; failed stores, stale hits and failed verifies are their own outcomes #1764).Closes #1777
🤖 Generated with Claude Code
https://claude.ai/code/session_01No1NznPsprjj92Cb5X6kkQ