Skip to content

Bump core-cpp to v0.21.0 - #1127

Merged
Yaraslaut merged 3 commits into
masterfrom
chore/core-cpp-0.21
Nov 16, 2026
Merged

Yaraslaut merged 3 commits into
masterfrom
chore/core-cpp-0.21

Conversation

@Yaraslaut

Copy link
Copy Markdown
Member

Summary

Moves the core-cpp pin from v0.7.0 to v0.21.0 (the MORPH_CORE_CPP_VERSION bound, GIT_TAG and VERSION), ahead of the shared-library work that needs a later core-cpp. Pure dependency bump: no shared-library changes.

Commits

  1. Pin core-cpp v0.21.0: pin and bound, cmake/CPM.cmake re-synced with core-cpp's copy, CORE_CPP_WITH_SYSTEMD=OFF, docs/BUILDING.md.
  2. Move morph::tui onto core-cpp 0.21's Buffer and ScreenConfig.
  3. Changelog entry.

Breaking changes in core-cpp 0.8 to 0.21 that touched morph

  • core::tui::Buffer::at() and tryAt() are gone; cellAt(Point) returns nullptr outside the buffer. Migrated src/tui/widget.cpp and the TUI tests.
  • ScreenConfig::alternateScreen (bool) is screenBuffer (ScreenBuffer::Primary or Alternate). Migrated src/tui/frontend.cpp.
  • 0.13 makes libsystemd and pkg-config a Linux default (CORE_CPP_WITH_SYSTEMD). morph does not watch the power state, so it passes OFF; the dependency set is unchanged.
  • cmake/CPM.cmake differs from core-cpp's in one place (an elseif honouring FASTCACHED_FETCH_SILENCE_SECONDS); its body is copied byte for byte again, as its header requires.
  • All the OPTIONS morph passes (CORE_CPP_TESTING, BUILD_EXAMPLES, WITH_TUI, WITH_IMAGES, WITH_TLS, FETCH_DEPS, INSTALL) still exist. Targets core::base/async/net/platform/tui are unchanged. libunicode stays 0.9.3, which is core-cpp's pin too.
  • The other listed breaks do not apply to morph: Component::onResize(Size) (no morph subclass declares one), remainingMs, IClock forward declarations, Terminal/ScreenSurface, core::cli, split, FakeSystemPowerMonitor, Windows UTF-8 paths, Sink::console() to stderr (grepped; morph uses none).

Semantics worth a reviewer's eye

  • 0.21: Screen now sizes its root to the viewport on every frame, and a component that leaves a Screen loses focus and hover there (a focused one hears onBlur(), deferred to the end of the tree change). morph::tui's overlays (OverlayCore::Frame) and view swaps hit this path. The TUI suite passes unchanged; I found no morph code reading root().area().
  • Nothing in core-cpp's executor, strand, net or coroutine behaviour is listed as changed in 0.8 to 0.21 Breaking sections; I read those sections, not every Changed or Fixed entry.

Verification (clang Debug, MORPH_BUILD_TUI/QT/QT_QUICK/NET/CLIENT/LADDER=ON)

  • Built the full tree including the application ladder (1145 steps): 0 errors, 0 warnings.
  • ctest with QT_QPA_PLATFORM=offscreen TMPDIR=/dev/shm, -j5: all 6472 tests ran. The build host's per-call limit cut the run into four invocations, so the result is the union of their logs: 6471 passed first time; test 2750 (FileOfflineQueue::enqueue: a short write does not brick the queue) failed once under -j5 with cannot rename ... compact-tmp in /dev/shm, and passed when run alone. That looks like a test-side temp-file collision, unrelated to core-cpp, but I did not reproduce or root-cause it.
  • scripts/check_install_export.sh: passes (consumer builds and runs).
  • g++ -std=c++23 -Wall -Wextra -Werror -fsyntax-only on src/tui/widget.cpp and src/tui/frontend.cpp: clean. The mechanical test edits were not compiled with g++.
  • clang-tidy 23 on the two source files: no finding on any changed line. Not run on the changed test files.
  • Branch-coverage allowlist: all 20 entries resolve, none moved.

Not verified

  • No gcc-release (-O3) build, no Windows or MSVC, no sanitizer or coverage legs, no WASM build.
  • No Tracy build (MORPH_ENABLE_TRACY): core-cpp 0.21 pins Tracy 0.14.1 for its own instrumentation, morph's pin is v0.13.1; morph does not turn core-cpp's Tracy on.
  • No run against an installed (found, not fetched) core-cpp.

🤖 Generated with Claude Code

https://claude.ai/code/session_01No1Nzo5wbYPDDynGBphgqj

Yaraslaut and others added 3 commits November 16, 2026 15:34
Moves the core-cpp pin and its find_package bound from 0.7 to 0.21,
re-syncs cmake/CPM.cmake with core-cpp's copy (it now also honours
FASTCACHED_FETCH_SILENCE_SECONDS), and passes CORE_CPP_WITH_SYSTEMD=OFF
so core-cpp's logind power monitor adds no libsystemd/pkg-config
requirement.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01No1Nzo5wbYPDDynGBphgqj
Buffer::at() and tryAt() are gone in favour of cellAt(Point), which
returns nullptr outside the buffer, and ScreenConfig::alternateScreen is
the ScreenBuffer enumeration screenBuffer. Behaviour is unchanged.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01No1Nzo5wbYPDDynGBphgqj
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01No1Nzo5wbYPDDynGBphgqj
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Yaraslaut
Yaraslaut merged commit 8e45193 into master Nov 16, 2026
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant