Repository navigation
Bump core-cpp to v0.21.0 - #1127
Merged
Merged
Conversation
Moves the core-cpp pin and its find_package bound from 0.7 to 0.21, re-syncs cmake/CPM.cmake with core-cpp's copy (it now also honours FASTCACHED_FETCH_SILENCE_SECONDS), and passes CORE_CPP_WITH_SYSTEMD=OFF so core-cpp's logind power monitor adds no libsystemd/pkg-config requirement. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01No1Nzo5wbYPDDynGBphgqj
Buffer::at() and tryAt() are gone in favour of cellAt(Point), which returns nullptr outside the buffer, and ScreenConfig::alternateScreen is the ScreenBuffer enumeration screenBuffer. Behaviour is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01No1Nzo5wbYPDDynGBphgqj
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01No1Nzo5wbYPDDynGBphgqj
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the core-cpp pin from v0.7.0 to v0.21.0 (the
MORPH_CORE_CPP_VERSIONbound,GIT_TAGandVERSION), ahead of the shared-library work that needs a later core-cpp. Pure dependency bump: no shared-library changes.Commits
cmake/CPM.cmakere-synced with core-cpp's copy,CORE_CPP_WITH_SYSTEMD=OFF,docs/BUILDING.md.BufferandScreenConfig.Breaking changes in core-cpp 0.8 to 0.21 that touched morph
core::tui::Buffer::at()andtryAt()are gone;cellAt(Point)returns nullptr outside the buffer. Migratedsrc/tui/widget.cppand the TUI tests.ScreenConfig::alternateScreen(bool) isscreenBuffer(ScreenBuffer::PrimaryorAlternate). Migratedsrc/tui/frontend.cpp.CORE_CPP_WITH_SYSTEMD). morph does not watch the power state, so it passes OFF; the dependency set is unchanged.cmake/CPM.cmakediffers from core-cpp's in one place (anelseifhonouringFASTCACHED_FETCH_SILENCE_SECONDS); its body is copied byte for byte again, as its header requires.OPTIONSmorph passes (CORE_CPP_TESTING,BUILD_EXAMPLES,WITH_TUI,WITH_IMAGES,WITH_TLS,FETCH_DEPS,INSTALL) still exist. Targetscore::base/async/net/platform/tuiare unchanged. libunicode stays 0.9.3, which is core-cpp's pin too.Component::onResize(Size)(no morph subclass declares one),remainingMs,IClockforward declarations,Terminal/ScreenSurface,core::cli,split,FakeSystemPowerMonitor, Windows UTF-8 paths,Sink::console()to stderr (grepped; morph uses none).Semantics worth a reviewer's eye
Screennow sizes its root to the viewport on every frame, and a component that leaves aScreenloses focus and hover there (a focused one hearsonBlur(), deferred to the end of the tree change). morph::tui's overlays (OverlayCore::Frame) and view swaps hit this path. The TUI suite passes unchanged; I found no morph code readingroot().area().Verification (clang Debug,
MORPH_BUILD_TUI/QT/QT_QUICK/NET/CLIENT/LADDER=ON)QT_QPA_PLATFORM=offscreen TMPDIR=/dev/shm,-j5: all 6472 tests ran. The build host's per-call limit cut the run into four invocations, so the result is the union of their logs: 6471 passed first time; test 2750 (FileOfflineQueue::enqueue: a short write does not brick the queue) failed once under-j5withcannot rename ... compact-tmpin/dev/shm, and passed when run alone. That looks like a test-side temp-file collision, unrelated to core-cpp, but I did not reproduce or root-cause it.scripts/check_install_export.sh: passes (consumer builds and runs).-std=c++23 -Wall -Wextra -Werror -fsyntax-onlyonsrc/tui/widget.cppandsrc/tui/frontend.cpp: clean. The mechanical test edits were not compiled with g++.Not verified
MORPH_ENABLE_TRACY): core-cpp 0.21 pins Tracy 0.14.1 for its own instrumentation, morph's pin is v0.13.1; morph does not turn core-cpp's Tracy on.🤖 Generated with Claude Code
https://claude.ai/code/session_01No1Nzo5wbYPDDynGBphgqj