Repository navigation
dsh: 适配 0.2.2-alpha.3(cordis Events symbol 索引),声明 manifestVersion / engines.dsh - #5
Merged
Merged
Conversation
…nes.dsh - ReloadCtxFace.on 事件参数改 string | symbol:cordis Events 新增 symbol 索引签名, 原 string 签名在 alpha.3 下 tsc 报 TS2345(src/index.ts:79) - package.json: dsh.manifestVersion=1,engines.dsh='>=0.2.1-alpha.2 <0.3.0-0';lib 重建
KyoMio
approved these changes
Nov 3, 2026
KyoMio
left a comment
Owner
There was a problem hiding this comment.
核对过:cordis 4.0.6-alpha.2 的 Events 确有 [key: symbol] 索引(实抽 typings 验证);semver 区间含 rc.5 / alpha.3、排 0.3.x 正确;本地 Node 22 全量 test:ci 817/0 过,CI 上 Node 22 挂的 D13(executor.recreated)本地复跑通过,判定为 flaky,与本 PR 改动无关。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
DSH 0.2.2-alpha.3 依赖 cordis 4.0.6-alpha.2,其
Events新增[key: symbol]: (...args) => any索引签名,keyof Events含 symbol 后Context不再可赋值给ReloadCtxFace,dsh-plugintsc报 TS2345(src/index.ts:79)。改动
dsh-plugin/src/reload.ts:ReloadCtxFace.on(event: string | symbol, …);lib 重建(仅 reload.d.ts 与 map 变化)package.json:dsh.manifestVersion: 1,engines.dsh: ">=0.2.1-alpha.2 <0.3.0-0"(含 latest 0.2.1-rc.5 与 0.2.2-alpha.3)。dsh-plugin/package.json 不动(守卫测试禁止该处有 dsh 字段)验证(隔离沙箱,无网络,Node 24.21.0)