Repository navigation
Revert #686 and #678: Project 4 work moves to the builtin-engines branch - #688
Merged
Merged
Conversation
KnifeLemon
added
the
built-in engines
8 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Takes the two Project 4 ("Filee: built-in engines") PRs back out of
main: #686 (resource limits and fuzzing for the document readers) and #678 (document model for rendering fidelity). The project is developed on thebuiltin-enginesbranch, which keeps both, and goes tomainonce it has been tested as a whole.git revert -m 1of both merge commits; nothing else changes. The PRs merged after them (feat(presets): a minimum short edge resize that only enlarges (#652) #687, feat(presets): Edit pictures, size, format and turn chosen each time (#584) #617, feat(images): pixelate or blur parts of a picture before sharing it #684, feat(images): Merge images, pictures one under another or side by side (#645) #682) don't use anything from them.mainas before them: the HWPX / DOCX / OFD / KML / GPX readers without the new limits, noerror.document_too_complexstring, no nightlyfuzz.yml.builtin-enginesis merged intomainlater, these reverts are reverted on that branch first, so the work comes back with it.Type of change
How was it tested?
dotnet build Filee.slnx -c Release: no errors🤖 Generated with Claude Code