Skip to content

fix: Draw punctuation and accented letters in the start-up banner's name - #231

Merged
Kkkermit merged 1 commit into
developfrom
testify/bugfix-14
Nov 19, 2026
Merged

Kkkermit merged 1 commit into
developfrom
testify/bugfix-14

Conversation

@Kkkermit

Copy link
Copy Markdown
Owner

What this changes

The start-up banner draws the bot's name in figlet's ANSI Shadow font. bigText in src/lib/bot/banner.util.ts only had glyphs for A–Z, 0–9 and -, and dropped every other character silently, so a bot called Fixxer2.0 was shown as FIXXER20.

  • Punctuation from the font itself: . , ! ? : ; _ / ( ) [ ] < > # $ % & * @ ^, copied row for row from ANSI Shadow.flf. The existing letters match that file exactly. The one change is the stray · beside the $, which became a space.
  • Drawn to match the font: ' " + = \ |. The font leaves these blank, so they are drawn in its style.
  • Accented letters are drawn as their plain letter: the name is NFD-normalised and its combining marks removed, so "Café" shows as CAFE.
  • Still skipped: characters the font cannot draw at all, as before. That means emoji, ~, {, } and the backtick.

Why

A bot's Discord username often contains punctuation, and the banner showed a different name from the one the bot has.

How to verify

  • npm run check passes (4,076 tests).
  • In tests/lib/bot/banner.test.ts, each new test was proved red by removing its fix:
    • Every punctuation mark draws as a six-row rectangle, and Fixxer2.0 is exactly one full stop wider than Fixxer20. Removing the . glyph fails it.
    • Café draws the same as Cafe. Removing the accent stripping fails it.
  • The two existing tests used ! as their example of a character with no glyph; they now use ✓.

Checklist

  • The branch is cut from develop, and this pull request targets develop
  • npm run check passes
  • Tests cover the new logic
  • No read-modify-save() on numeric fields (no data code touched)
  • Embeds come from the embed() factory (none touched)
  • No raw console.*
  • Every promise is awaited
  • Timers are registered with the timer registry (none added)
  • New custom IDs use the codec and a unique namespace (none added)
  • New environment variables are in src/config/env.ts and scripts/setupEnv.ts (none added)
  • npm run docs:commands re-run if a command changed (no command changed)
  • Documentation updated if behaviour changed (nothing documents the banner's characters)

Generated by Claude Code

@Kkkermit
Kkkermit merged commit f0b7084 into develop Nov 19, 2026
8 checks passed
@Kkkermit
Kkkermit deleted the testify/bugfix-14 branch November 19, 2026 11:56
@Kkkermit Kkkermit mentioned this pull request Nov 19, 2026
13 of 15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant