Repository navigation
fix: Draw punctuation and accented letters in the start-up banner's name - #231
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The start-up banner draws the bot's name in figlet's ANSI Shadow font.
bigTextinsrc/lib/bot/banner.util.tsonly had glyphs for A–Z, 0–9 and-, and dropped every other character silently, so a bot called Fixxer2.0 was shown as FIXXER20.. , ! ? : ; _ / ( ) [ ] < > # $ % & * @ ^, copied row for row fromANSI Shadow.flf. The existing letters match that file exactly. The one change is the stray·beside the$, which became a space.' " + = \ |. The font leaves these blank, so they are drawn in its style.~,{,}and the backtick.Why
A bot's Discord username often contains punctuation, and the banner showed a different name from the one the bot has.
How to verify
npm run checkpasses (4,076 tests).tests/lib/bot/banner.test.ts, each new test was proved red by removing its fix:Fixxer2.0is exactly one full stop wider thanFixxer20. Removing the.glyph fails it.Cafédraws the same asCafe. Removing the accent stripping fails it.!as their example of a character with no glyph; they now use✓.Checklist
develop, and this pull request targetsdevelopnpm run checkpassessave()on numeric fields (no data code touched)embed()factory (none touched)console.*src/config/env.tsandscripts/setupEnv.ts(none added)npm run docs:commandsre-run if a command changed (no command changed)Generated by Claude Code