Repository navigation
chore: Clear the install warnings and drop the withdrawn picomatch suppression - #229
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
npm ciinstalls with no warnings:"undici@^5": "^6.29.1"entry, not one nested underdiscord-html-transcripts. npm 11.6, the version that ships with Node 24.11, prints a spuriousERESOLVE overriding peer dependencyfor a nested override on a package with peer dependencies. npm 10.9 and 11.21 do not.^29.1.1, andbetter-npm-auditis updated to 4.2.1. This removes the deprecatedwhatwg-encodingandlodash.getfrom the tree..nsprcentry for advisory 1247710 is removed, because the advisory was withdrawn.jsdom 29 gives a
<span>display: inline, and an accessible name then joins flex items and block spans with no space where a browser puts one. Four dashboard tests failed on that.dashboard/src/test/setup.tsnow adds the display rules a name depends on. I checked against the built CSS in Chromium that the browser computes the same names the tests now expect. The override table indocs/security.md,docs/future-feature.mdand AGENTS §24 cover the changes.Why
The ERESOLVE and deprecation warnings showed on every
npm ci, which looks like a broken install to anybody cloning the bot.How to verify
rm -rf node_modules && npm ciprints no ERESOLVE and no deprecation warnings. I checked this with npm 10.9.4, 11.6.1 and 11.21.1.npm run checkpasses.npm run auditpasses with the picomatch entry gone.Checklist
develop, and this pull request targetsdevelopnpm run checkpassessave()on numeric fields (no data code touched)embed()factory (none touched)console.*src/config/env.tsandscripts/setupEnv.ts(none added)npm run docs:commandsre-run if a command changed (no command changed)Generated by Claude Code