Skip to content

chore: Clear the install warnings and drop the withdrawn picomatch suppression - #229

Merged
Kkkermit merged 1 commit into
developfrom
testify/chore-38
Nov 19, 2026
Merged

Kkkermit merged 1 commit into
developfrom
testify/chore-38

Conversation

@Kkkermit

Copy link
Copy Markdown
Owner

What this changes

npm ci installs with no warnings:

  • The undici override is now a top-level "undici@^5": "^6.29.1" entry, not one nested under discord-html-transcripts. npm 11.6, the version that ships with Node 24.11, prints a spurious ERESOLVE overriding peer dependency for a nested override on a package with peer dependencies. npm 10.9 and 11.21 do not.
  • jsdom is held at ^29.1.1, and better-npm-audit is updated to 4.2.1. This removes the deprecated whatwg-encoding and lodash.get from the tree.
  • The .nsprc entry for advisory 1247710 is removed, because the advisory was withdrawn.

jsdom 29 gives a <span> display: inline, and an accessible name then joins flex items and block spans with no space where a browser puts one. Four dashboard tests failed on that. dashboard/src/test/setup.ts now adds the display rules a name depends on. I checked against the built CSS in Chromium that the browser computes the same names the tests now expect. The override table in docs/security.md, docs/future-feature.md and AGENTS §24 cover the changes.

Why

The ERESOLVE and deprecation warnings showed on every npm ci, which looks like a broken install to anybody cloning the bot.

How to verify

  • rm -rf node_modules && npm ci prints no ERESOLVE and no deprecation warnings. I checked this with npm 10.9.4, 11.6.1 and 11.21.1.
  • npm run check passes.
  • npm run audit passes with the picomatch entry gone.

Checklist

  • The branch is cut from develop, and this pull request targets develop
  • npm run check passes
  • Tests cover the new logic (the four accessible-name tests, unchanged, now pass under jsdom 29)
  • No read-modify-save() on numeric fields (no data code touched)
  • Embeds come from the embed() factory (none touched)
  • No raw console.*
  • Every promise is awaited
  • Timers are registered with the timer registry (none added)
  • New custom IDs use the codec and a unique namespace (none added)
  • New environment variables are in src/config/env.ts and scripts/setupEnv.ts (none added)
  • npm run docs:commands re-run if a command changed (no command changed)
  • Documentation updated if behaviour changed

Generated by Claude Code

@Kkkermit
Kkkermit merged commit 78d9b0a into develop Nov 19, 2026
8 checks passed
@Kkkermit
Kkkermit deleted the testify/chore-38 branch November 19, 2026 11:16
@Kkkermit Kkkermit mentioned this pull request Nov 19, 2026
13 of 15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant