comp: fix vtkAddon library not found - #12
Closed
UlysseDurand wants to merge 1 commit into
Closed
UlysseDurand wants to merge 1 commit into
UlysseDurand wants to merge 1 commit into
Conversation
UlysseDurand
force-pushed
the
fix-vtk-addon
branch
from
August 21, 2026 08:07
b8e5e24 to
b740699
Compare
Collaborator
|
@Thibault-Pelletier Ok, steve's changes did broke slicer core lol, the find_package python now fails because the embed component does not exist at all. @UlysseDurand Can you please add "-DVTK_UNDEFINED_SYMBOLS_ALLOWED:BOOL=ON" to vtkAddon build arguments in External_vtkAddon.cmake? |
UlysseDurand
force-pushed
the
fix-vtk-addon
branch
from
August 21, 2026 11:49
b740699 to
45ec867
Compare
Contributor
Author
|
@AlexyPellegrini sure, I just amended the last commit 45ec867 |
Collaborator
|
I think you forgot to stage changes before commiting |
UlysseDurand
force-pushed
the
fix-vtk-addon
branch
from
August 21, 2026 12:00
45ec867 to
bf2c821
Compare
Contributor
Author
|
Yes, my bad, it should be good now |
Collaborator
|
vtkImageMapToWindowLevelAddon is not built in slicer, I guess it is a new class so it needs to be added to class list of MRMLCore module |
Collaborator
|
replaced by #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the vtkAddon not found while building SlicerCore.