Repository navigation
fix: stabilize slice clipping and tighten visual checks - #990
Merged
Merged
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
changed the title
PaulHax
force-pushed
the
layer-display-ci
branch
from
October 25, 2026 18:00
5ad5556 to
0ca8665
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After replacing an oblique layout, hiding and showing the base image can change its camera clipping range because resize uses slice actor bounds while visibility restoration uses full image bounds. Use the full image bounds consistently during slice-view resize, and retain separate before, hidden, and restored screenshots for each visibility cycle. Keep immediate resizing tied to dimension changes so replacing image data can update its mappers before rendering.
Refresh the axial painting and coronal labelmap baselines with the pointer outside the view, and reduce their allowed pixel mismatch from 5% to 0.01%. Capture the composited viewport with the text overlays hidden so the comparison checks the image and painted geometry independently of font rasterization. Use the same threshold for difference warnings, and keep the checks that brush hovering leaves the painted image unchanged.
The overlay lifecycle test can exceed its timeout when view conversion and session restoration run together. Split those paths into separate cases and use a single-slice fixture for the save/reopen case, while retaining coverage of converting all three slice views.