Repository navigation
fix(data-browser): expand the panel of newly loaded data - #1010
Open
ShivaBollam07 wants to merge 1 commit into
Open
ShivaBollam07 wants to merge 1 commit into
ShivaBollam07 wants to merge 1 commit into
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
force-pushed
the
fix/expand-panel-of-loaded-data
branch
2 times, most recently
from
November 1, 2026 15:14
0f15f60 to
e5e942b
Compare
The panels were only opened when the set of patients or the presence of non-DICOM images changed, so loading another image or a new study for an existing patient left a collapsed panel collapsed. Open the panel whenever new images or volumes appear, without adding duplicate keys.
PaulHax
force-pushed
the
fix/expand-panel-of-loaded-data
branch
from
November 1, 2026 16:15
e5e942b to
1bad09b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #233
Problem
The data browser only expanded panels when
hasAnonymousImagesor the list of patients changed. Loading another non-DICOM image, or a new study for a patient that is already listed, changes neither, so a panel the user had collapsed stayed collapsed and the new data was not visible. The watcher also pushed keys that were already inpanels.Fix
Watch the loaded non-DICOM image IDs and the volumes of each patient instead, and expand the matching panel when new ones appear. A key is only added if it is not already open, and the sample data panel is still closed once data is loaded.
Testing
src/components/__tests__/DataBrowser.spec.ts: a patient panel is collapsed and a second study of that patient is loaded. Fails on main (expected [] to deeply equal [ 'patient' ]), passes with the change.npx vitest --run: 195 files / 2067 tests pass;eslint,prettier --checkandvue-tsc --noEmitclean.