Repository navigation
fix(annotations): list measurements in the order they were placed - #1009
ShivaBollam07 wants to merge 1 commit into
Conversation
❌ Deploy Preview for volview-dev failed.Built without sensitive environment variables
|
5673bd1 to
0ca5a56
Compare
|
Thank you for taking this on. I prefer, or we're trying to stick with, like a linear history. So never do any merge commits, like what you just did eight hours ago with merging main into this. So do a clean rebase. Make sure that the test quality is high. No need for a testing section inside of the commit, or inside of the PR message. And thank you for your contribution. Of course, can you apply these same principles to your other PR? |
|
Thanks for the review, and sorry about the merge commit. I'll rebase this onto main to remove it and keep the history linear, and I'll keep to rebasing from now on. I've removed the Testing section from the description of this PR and #1010. The commit messages don't have one. I'll also go back over the tests in both PRs, and rebase #1010 as well. |
Each view creates its placing tool ahead of time, so tool IDs follow the creation of those placeholders rather than the order annotations are finished, and a new ruler could show up in the middle of the Measurements list. Move a tool to the end of the tool list when it is placed.
be472b9 to
7e532da
Compare
|
Rebased this and #1010 onto main, so each is now one commit with no merge commits, and removed the Testing sections. Unit tests and The Netlify deploy preview is failing on both PRs, and I don't have access to the deploy log to see the error. Could you take a look when you get a chance? |
Fixes #378
Problem
Each view creates its "placing" tool ahead of time, so the order of
toolIDsfollows when those placeholders were created, not when annotations are finished. With the steps from the issue (ruler in the lower left view, then in the upper left view) the last drawn ruler ends up first in the Measurements list.Fix
placeTool()moves the tool to the end oftoolIDswhen it is placed, sofinishedTools, the Measurements list and the saved tool order follow placement order. No new field or state file change. Tools stay grouped by type in the list, as before.