Skip to content

Tools: Replace WP_Filesystem with file_get_contents #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n7studios merged 1 commit into from
Aug 28, 2026
Merged

Tools: Replace WP_Filesystem with file_get_contents #1175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 5 additions & 25 deletions admin/section/class-convertkit-admin-section-tools.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ class ConvertKit_Admin_Section_Tools extends ConvertKit_Admin_Section_Base {
*/
public function __construct() {

// Initialize WP_Filesystem.
require_once ABSPATH . 'wp-admin/includes/file.php';
WP_Filesystem();

$this->settings_key = '_wp_convertkit_tools'; // Required for ConvertKit_Settings_Base, but we don't save settings on the Tools screen.
$this->name = 'tools';
$this->title = __( 'Tools', 'convertkit' );
Expand Down Expand Up @@ -125,8 +121,6 @@ private function maybe_clear_log() {
*/
private function maybe_download_log() {

global $wp_filesystem;

// Bail if nonce verification fails.
if ( ! isset( $_REQUEST['_convertkit_settings_tools_nonce'] ) ) {
return;
Expand All @@ -149,7 +143,8 @@ private function maybe_download_log() {
header( 'Content-Disposition: attachment; filename=convertkit-log.txt' );
header( 'Pragma: no-cache' );
header( 'Expires: 0' );
echo esc_html( $wp_filesystem->get_contents( $log->get_filename() ) );
// phpcs:ignore WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents
echo esc_html( (string) file_get_contents( $log->get_filename() ) );
exit();

}
Expand All @@ -162,8 +157,6 @@ private function maybe_download_log() {
*/
private function maybe_download_system_info() {

global $wp_filesystem;

// Bail if nonce verification fails.
if ( ! isset( $_REQUEST['_convertkit_settings_tools_nonce'] ) ) {
return;
Expand All @@ -181,21 +174,12 @@ private function maybe_download_system_info() {
// Get System Info.
$system_info = $this->get_system_info();

// Write contents to temporary file.
$tmpfile = tmpfile();
$filename = stream_get_meta_data( $tmpfile )['uri'];
$wp_filesystem->put_contents(
$filename,
esc_attr( $system_info )
);

// Download.
header( 'Content-type: application/octet-stream' );
header( 'Content-Disposition: attachment; filename=convertkit-system-info.txt' );
header( 'Pragma: no-cache' );
header( 'Expires: 0' );
echo esc_html( $wp_filesystem->get_contents( $filename ) );
$wp_filesystem->delete( $filename );
echo esc_html( $system_info );
exit();

}
Expand Down Expand Up @@ -263,11 +247,6 @@ private function maybe_import_configuration() {
return;
}

// Allow us to easily interact with the filesystem.
require_once ABSPATH . 'wp-admin/includes/file.php';
WP_Filesystem();
global $wp_filesystem;

// Bail if the submit button for importing the configuration was not clicked.
if ( ! array_key_exists( 'convertkit-import', $_REQUEST ) ) {
return;
Expand All @@ -284,7 +263,8 @@ private function maybe_import_configuration() {
}

// Read file.
$json = $wp_filesystem->get_contents( sanitize_text_field( wp_unslash( $_FILES['import']['tmp_name'] ) ) );
// phpcs:ignore WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents
$json = file_get_contents( sanitize_text_field( wp_unslash( $_FILES['import']['tmp_name'] ) ) );

// Decode.
$import = json_decode( $json, true );
Expand Down